Configuration.readQoS

Author: groue

GRDB/Core/Configuration.swift

@@ -248,6 +248,11 @@ public struct Configuration {
     /// Default: .default
     public var qos: DispatchQoS = .default
 
+    /// The quality of service of read accesses
+    var readQoS: DispatchQoS {
+        targetQueue?.qos ?? self.qos
+    }
+    
     /// A target queue for database accesses.
     ///
     /// Database connections which are not read-only will prefer
@@ -316,17 +321,4 @@ public struct Configuration {
             return DispatchQueue(label: label, qos: qos)
         }
     }
-    
-    /// Creates a DispatchQueue which has the quality of service of
-    /// read accesses.
-    ///
-    /// The returned queue has no target queue, and won't create deadlocks when
-    /// used synchronously from a database access.
-    func makeDispatchQueue(label: String) -> DispatchQueue {
-        if let targetQueue = targetQueue {
-            return DispatchQueue(label: label, qos: targetQueue.qos)
-        } else {
-            return DispatchQueue(label: label, qos: qos)
-        }
-    }
 }

GRDB/ValueObservation/ValueConcurrentObserver.swift

@@ -138,9 +138,11 @@ final class ValueConcurrentObserver<Reducer: ValueReducer> {
             fetch: reducer._fetch)
         self.notificationCallbacks = NotificationCallbacks(events: events, onChange: onChange)
         self.reducer = reducer
-        self.reduceQueue = dbPool.configuration.makeDispatchQueue(label: dbPool.configuration.identifier(
-            defaultLabel: "GRDB",
-            purpose: "ValueObservation"))
+        self.reduceQueue = DispatchQueue(
+            label: dbPool.configuration.identifier(
+                defaultLabel: "GRDB",
+                purpose: "ValueObservation"),
+            qos: dbPool.configuration.readQoS)
     }
 }
 

GRDB/ValueObservation/ValueWriteOnlyObserver.swift

@@ -139,9 +139,11 @@ final class ValueWriteOnlyObserver<Writer: DatabaseWriter, Reducer: ValueReducer
             fetch: reducer._fetch)
         self.notificationCallbacks = NotificationCallbacks(events: events, onChange: onChange)
         self.reducer = reducer
-        self.reduceQueue = writer.configuration.makeDispatchQueue(label: writer.configuration.identifier(
-            defaultLabel: "GRDB",
-            purpose: "ValueObservation"))
+        self.reduceQueue = DispatchQueue(
+            label: writer.configuration.identifier(
+                defaultLabel: "GRDB",
+                purpose: "ValueObservation"),
+            qos: writer.configuration.readQoS)
     }
 }