server: dropped events in stream when resuming with minseq

Author: jclulow

github/server/src/variety/basic.rs

@@ -1620,7 +1620,9 @@ pub(crate) async fn details(
              */
             out += "function basic_onload() {}\n";
         } else {
-            out += &app.templates.load("variety/basic/live.js")?
+            out += &app
+                .templates
+                .load("variety/basic/live.js")?
                 .replace("%LOCAL_TIME%", &local_time.to_string())
                 .replace("%CHECKRUN%", &cr.id.to_string())
                 .replace("%MINSEQ%", &minseq.to_string());

server/src/api/user.rs

@@ -155,9 +155,13 @@ pub(crate) async fn job_watch(
      */
     let mut resuming = false;
     if let Some(minseq) =
-        query.into_inner().minseq.and_then(|n| n.try_into().ok())
+        query.into_inner().minseq.and_then(|n| u32::try_from(n).ok())
     {
-        seq = minseq;
+        /*
+         * The "seq" value refers to the last record we have seen, but the
+         * "minseq" parameter specifies the next record we _want_ to see.
+         */
+        seq = minseq.saturating_sub(1);
         if minseq > 1 {
             resuming = true;
         }