Skip to content

Commit d4072e3

Browse files
authored
Merge pull request #57 from oxidecomputer/wc/windows-codesign
Enable codesigning for Windows
2 parents 1c14952 + e73b400 commit d4072e3

File tree

5 files changed

+18
-8
lines changed

5 files changed

+18
-8
lines changed

.github/workflows/release.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
# we specify bash to get pipefail; it guards against the `curl` command
6767
# failing. otherwise `sh` won't catch that `curl` returned non-0
6868
shell: bash
69-
run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/oxidecomputer/cargo-dist/releases/download/v1.0.6/dist-installer.sh | sh"
69+
run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/oxidecomputer/cargo-dist/releases/download/v1.0.7/dist-installer.sh | sh"
7070
- name: Cache dist
7171
uses: actions/upload-artifact@v4
7272
with:
@@ -114,6 +114,10 @@ jobs:
114114
env:
115115
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
116116
BUILD_MANIFEST_NAME: target/distrib/${{ join(matrix.targets, '-') }}-dist-manifest.json
117+
SSLDOTCOM_USERNAME: ${{ secrets.SSLDOTCOM_USERNAME }}
118+
SSLDOTCOM_PASSWORD: ${{ secrets.SSLDOTCOM_PASSWORD }}
119+
SSLDOTCOM_CREDENTIAL_ID: ${{ secrets.SSLDOTCOM_CREDENTIAL_ID }}
120+
SSLDOTCOM_TOTP_SECRET: ${{ secrets.SSLDOTCOM_TOTP_SECRET }}
117121
CODESIGN_CERTIFICATE: ${{ secrets.CODESIGN_CERTIFICATE }}
118122
CODESIGN_CERTIFICATE_PASSWORD: ${{ secrets.CODESIGN_CERTIFICATE_PASSWORD }}
119123
CODESIGN_IDENTITY: ${{ secrets.CODESIGN_IDENTITY }}

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
Nothing Yet!
44

5+
# Version 1.0.8 (2025-07-11)
6+
7+
- Codesign Windows binaries.
8+
59
# Version 1.0.7 (2025-07-04)
610

711
- Fix long lines in Homebrew formula.

Cargo.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ edition = "2021"
1818
license = "MIT OR Apache-2.0"
1919
repository = "https://github.com/oxidecomputer/cargo-dist"
2020
homepage = "https://opensource.axo.dev/cargo-dist/"
21-
version = "1.0.7"
21+
version = "1.0.8"
2222
rust-version = "1.88"
2323

2424
[workspace.dependencies]
2525
# intra-workspace deps (you need to bump these versions when you cut releases too!
26-
dist-schema = { version = "=1.0.7", path = "cargo-dist-schema" }
27-
axoproject = { version = "=1.0.7", path = "axoproject", default-features = false, features = ["cargo-projects", "generic-projects", "npm-projects"] }
26+
dist-schema = { version = "=1.0.8", path = "cargo-dist-schema" }
27+
axoproject = { version = "=1.0.8", path = "axoproject", default-features = false, features = ["cargo-projects", "generic-projects", "npm-projects"] }
2828

2929
# vendored first-party deps
3030
axocli = { version = "0.2.0", path = "vendor/axocli" }

dist-workspace.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ members = ["cargo:."]
44
# Config for 'dist'
55
[dist]
66
# The preferred dist version to use in CI (Cargo.toml SemVer syntax)
7-
cargo-dist-version = "1.0.6"
7+
cargo-dist-version = "1.0.7"
88
# CI backends to support
99
ci = "github"
1010
# The installers to generate for each app
@@ -23,6 +23,8 @@ github-attestations = true
2323
install-path = "CARGO_HOME"
2424
# Whether to sign macOS executables
2525
macos-sign = true
26+
# Whether to sign Windows executables
27+
ssldotcom-windows-sign = "prod"
2628
# A GitHub repo to push Homebrew formulas to
2729
tap = "oxidecomputer/homebrew-tap"
2830
# Publish jobs to run in CI

0 commit comments

Comments
 (0)