Skip to content

Commit 07aa5ae

Browse files
authored
Update dendrite and maghemite auto-prs (#3740)
Updates the creation / update mechanism that is used for creating dendrite and maghemite update PRs. Previously only GitHub `push` events could be used as a notification source. This caused an issue as the artifacts necessary for updating were still in the process of being built by a buildomat job. To work around this a long (1 hour) debounce delay was used so that by the time PR creation logic ran, the artifacts should have been generated. Now that `check_run` events are available, they can be used to more accurately specify when PR creation should run. This update changes the dendrite and maghemite listeners to listen for the completion of the `image` buildomat job in their respective repos. Resolves #3259
1 parent be647f6 commit 07aa5ae

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

.github/reflector/update-dendrite.toml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,10 @@ branch = "main"
99

1010
requires_token = true
1111

12-
# Debounce values are used to batch together multiple pushes that occur in a relatively short
13-
# timeframe
12+
# Run in response to the image buildomat job in dendrite completing
1413

1514
[[on]]
1615
repository = "oxidecomputer/dendrite"
17-
paths = [
18-
"**",
19-
]
20-
21-
# Wait one hour for binary builds to complete
22-
debounce = 3600
16+
event = "check_run"
17+
action = "completed"
18+
check = "image"

.github/reflector/update-maghemite.toml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,10 @@ branch = "main"
99

1010
requires_token = true
1111

12-
# Debounce values are used to batch together multiple pushes that occur in a relatively short
13-
# timeframe
12+
# Run in response to the image buildomat job in maghemite completing
1413

1514
[[on]]
1615
repository = "oxidecomputer/maghemite"
17-
paths = [
18-
"**",
19-
]
20-
21-
# Wait one hour for binary builds to complete
22-
debounce = 3600
16+
event = "check_run"
17+
action = "completed"
18+
check = "image"

0 commit comments

Comments
 (0)