[31/n] [reconfigurator-cli] add inventory-show command (#8617)

Use the display logic implemented in #8613 to show inventory collections
in reconfigurator-cli.

I had to change some of the timestamps to be in RFC 3339 format to allow
redactions to work properly.

Kind of addresses #8611, in the sense that we now have tests that render
collection output and ensure it looks reasonable.

Author: sunshowers

dev-tools/reconfigurator-cli/src/lib.rs

@@ -41,6 +41,7 @@ use nexus_types::deployment::{
 use nexus_types::deployment::{OmicronZoneNic, TargetReleaseDescription};
 use nexus_types::external_api::views::SledPolicy;
 use nexus_types::external_api::views::SledProvisionPolicy;
+use nexus_types::inventory::CollectionDisplayCliFilter;
 use omicron_common::address::REPO_DEPOT_PORT;
 use omicron_common::api::external::Name;
 use omicron_common::api::external::{Generation, TufRepoDescription};
@@ -236,6 +237,7 @@ fn process_command(
         Commands::SiloRemove(args) => cmd_silo_remove(sim, args),
         Commands::InventoryList => cmd_inventory_list(sim),
         Commands::InventoryGenerate => cmd_inventory_generate(sim),
+        Commands::InventoryShow(args) => cmd_inventory_show(sim, args),
         Commands::BlueprintList => cmd_blueprint_list(sim),
         Commands::BlueprintBlippy(args) => cmd_blueprint_blippy(sim, args),
         Commands::BlueprintEdit(args) => cmd_blueprint_edit(sim, args),
@@ -298,6 +300,8 @@ enum Commands {
     InventoryList,
     /// generates an inventory collection from the configured sleds
     InventoryGenerate,
+    /// show details about an inventory collection
+    InventoryShow(InventoryShowArgs),
 
     /// list all blueprints
     BlueprintList,
@@ -511,9 +515,16 @@ struct SiloAddRemoveArgs {
 }
 
 #[derive(Debug, Args)]
-struct InventoryArgs {
-    /// id of the inventory collection to use in planning
-    collection_id: CollectionUuid,
+struct InventoryShowArgs {
+    /// id of the inventory collection to show or "latest"
+    collection_id: CollectionIdOpt,
+
+    /// show long strings in their entirety
+    #[clap(long)]
+    show_long_strings: bool,
+
+    #[clap(subcommand)]
+    filter: Option<CollectionDisplayCliFilter>,
 }
 
 #[derive(Debug, Args)]
@@ -992,14 +1003,6 @@ enum CliDnsGroup {
     External,
 }
 
-#[derive(Debug, Args)]
-struct BlueprintDiffInventoryArgs {
-    /// id of the inventory collection
-    collection_id: CollectionUuid,
-    /// id of the blueprint, "latest", or "target"
-    blueprint_id: BlueprintIdOpt,
-}
-
 #[derive(Debug, Args)]
 struct BlueprintSaveArgs {
     /// id of the blueprint, "latest", or "target"
@@ -1463,6 +1466,24 @@ fn cmd_inventory_generate(
     Ok(Some(rv))
 }
 
+fn cmd_inventory_show(
+    sim: &mut ReconfiguratorSim,
+    args: InventoryShowArgs,
+) -> anyhow::Result<Option<String>> {
+    let state = sim.current_state();
+    let system = state.system();
+    let resolved = system.resolve_collection_id(args.collection_id.into())?;
+    let collection = system.get_collection(&resolved)?;
+
+    let mut display = collection.display();
+    if let Some(filter) = &args.filter {
+        display.apply_cli_filter(filter);
+    }
+    display.show_long_strings(args.show_long_strings);
+
+    Ok(Some(display.to_string()))
+}
+
 fn cmd_blueprint_list(
     sim: &mut ReconfiguratorSim,
 ) -> anyhow::Result<Option<String>> {

dev-tools/reconfigurator-cli/tests/input/cmds-example.txt

@@ -52,6 +52,7 @@ load-example --seed test-basic --nsleds 3 --sled-policy 1:non-provisionable --sl
 
 blueprint-list
 blueprint-show latest
+inventory-show latest
 
 # Plan a blueprint run -- this will cause zones and disks on the expunged
 # sled to be expunged.