Move SWITCH_ZONE_BASEBOARD_FILE to sled-agent-types (#7669)

This allows us to remove the dependency on sled-agent in zone-setup,
which is pulled in for a single type definition.

Without this change a debug build currently relies on libnvme.so, while
the compiler is able to elide this library on a release build:
```
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 14s
Error: Found library issues with the following:
nexus
        UNEXPECTED dependency on libsqlite3.so.0
omicron-dev
        UNEXPECTED dependency on libsqlite3.so.0
zone-setup
        NEEDS libnvme.so.1 but is not allowed


If depending on a new library was intended please add it to xtask.toml

```

And after this change we no longer depend on it in debug/release builds:
```
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s
Error: Found library issues with the following:
nexus
        UNEXPECTED dependency on libsqlite3.so.0
omicron-dev
        UNEXPECTED dependency on libsqlite3.so.0


If depending on a new library was intended please add it to xtask.toml
```

Author: papertigers

Cargo.lock

@@ -98,6 +98,7 @@ use omicron_ddm_admin_client::{Client as DdmAdminClient, DdmError};
 use omicron_uuid_kinds::OmicronZoneUuid;
 use rand::prelude::SliceRandom;
 use sled_agent_types::{
+    sled::SWITCH_ZONE_BASEBOARD_FILE,
     time_sync::TimeSync,
     zone_bundle::{ZoneBundleCause, ZoneBundleMetadata},
 };
@@ -138,8 +139,6 @@ const CLICKHOUSE_KEEPER_BINARY: &str =
     "/opt/oxide/clickhouse_keeper/clickhouse";
 const CLICKHOUSE_BINARY: &str = "/opt/oxide/clickhouse/clickhouse";
 
-pub const SWITCH_ZONE_BASEBOARD_FILE: &str = "/opt/oxide/baseboard.json";
-
 #[derive(thiserror::Error, Debug, slog_error_chain::SlogInlineError)]
 pub enum Error {
     #[error("Failed to initialize CockroachDb: {err}")]

sled-agent/src/services.rs

@@ -17,6 +17,8 @@ use serde::{Deserialize, Serialize};
 use sha3::{Digest, Sha3_256};
 use uuid::Uuid;
 
+pub const SWITCH_ZONE_BASEBOARD_FILE: &str = "/opt/oxide/baseboard.json";
+
 /// A representation of a Baseboard ID as used in the inventory subsystem
 /// This type is essentially the same as a `Baseboard` except it doesn't have a
 /// revision or HW type (Gimlet, PC, Unknown).

sled-agent/types/src/sled.rs

@@ -17,9 +17,9 @@ omicron-common.workspace = true
 omicron-workspace-hack.workspace = true
 oxnet.workspace = true
 serde_json.workspace = true
+sled-agent-types.workspace = true
 sled-hardware-types.workspace = true
 slog.workspace = true
 tokio.workspace = true
 uzers.workspace = true
 zone.workspace = true
-omicron-sled-agent.workspace = true

zone-setup/Cargo.toml

@@ -18,8 +18,8 @@ use illumos_utils::ExecutionError;
 use omicron_common::backoff::{retry_notify, retry_policy_local, BackoffError};
 use omicron_common::cmd::fatal;
 use omicron_common::cmd::CmdError;
-use omicron_sled_agent::services::SWITCH_ZONE_BASEBOARD_FILE;
 use oxnet::Ipv6Net;
+use sled_agent_types::sled::SWITCH_ZONE_BASEBOARD_FILE;
 use sled_hardware_types::underlay::BOOTSTRAP_PREFIX;
 use slog::{info, Logger};
 use std::fmt::Write as _;