api_versions! should make public Semver consts (#8322)

they were private, so it was impossible to use version constants defined
in a separate API crate. this is the relationship between the DNS server
and DNS API types, as one example, so move that explicit `Semver`
declaration to one from the `dns-server-api` crate.

Author: iximeow

Cargo.lock

@@ -106,9 +106,9 @@ impl SupportedVersions {
 /// these, equivalent to:
 ///
 /// ```
-///     const VERSION_ADD_FOOBAR_OPERATION: semver::Version =
+///     pub const VERSION_ADD_FOOBAR_OPERATION: semver::Version =
 ///         semver::Version::new(2, 0, 0);
-///     const VERSION_INITIAL: semver::Version =
+///     pub const VERSION_INITIAL: semver::Version =
 ///         semver::Version::new(1, 0, 0);
 /// ```
 ///
@@ -147,7 +147,7 @@ macro_rules! api_versions {
     ) ),* $(,)? ] ) => {
         openapi_manager_types::paste! {
             $(
-                const [<VERSION_ $name>]: semver::Version =
+                pub const [<VERSION_ $name>]: semver::Version =
                     semver::Version::new($major, 0, 0);
             )*
 
@@ -178,7 +178,7 @@ macro_rules! api_versions_picky {
     ) ),* $(,)? ] ) => {
         openapi_manager_types::paste! {
             $(
-                const [<VERSION_ $name>]: semver::Version =
+                pub const [<VERSION_ $name>]: semver::Version =
                     semver::Version::new($major, $minor, $patch);
             )*
 

dev-tools/openapi-manager/types/src/versions.rs

@@ -100,7 +100,7 @@ pub async fn start_servers(
                 "api-version"
                     .parse::<http::header::HeaderName>()
                     .expect("api-version is a valid header name"),
-                semver::Version::new(2, 0, 0),
+                dns_server_api::VERSION_SOA_AND_NS,
             ),
         )))
         .start()

dns-server/src/lib.rs

@@ -25,6 +25,7 @@ anyhow.workspace = true
 assert_matches.workspace = true
 dropshot.workspace = true
 dns-server.workspace = true
+dns-server-api.workspace = true
 dns-service-client.workspace = true
 expectorate.workspace = true
 omicron-test-utils.workspace = true

internal-dns/resolver/Cargo.toml

@@ -878,7 +878,7 @@ mod test {
                     "api-version"
                         .parse::<reqwest::header::HeaderName>()
                         .expect("api-version is a valid header name"),
-                    semver::Version::new(2, 0, 0),
+                    dns_server_api::VERSION_SOA_AND_NS,
                 ),
             )))
             .start()