`oxide system hardware switch list` returns empty list

[elaine-oxide]

I am running a4x2 with the following combination of commits:

• omicron 6dd980251a26430466bcd5aff1edad5416cf94e5
• maghemite 242e67e1e6b363b9bae04c90920fb8f43ac0a51d
• oxnet 7dacd265f1bcd0f8b47bd4805250c4f0812da206

I am using the version of the Oxide CLI from oxidecomputer/oxide.rs#795, with commit 6fbbd5568289e95432ed7adfb6808c3d3cd0e3f0:

$ oxide version
Oxide CLI 0.6.1+20240710.0
Built from commit: 6fbbd5568289e95432ed7adfb6808c3d3cd0e3f0 
Oxide API: 20240821.0

I ran the following command, and I was hoping to see values like switch0 and switch1, but I instead got an empty list.

$ oxide system hardware switch list
[]

I ran this command, but I don't understand the difference between switch_location and switch, and whether switch_location should appear in the output of the above command.

$ oxide system hardware switch-port list
[
  {
    "id": "<omitted>3761",
    "port_name": "qsfp1",
    "rack_id": "51becb40-1818-4ea0-b278-2af26bc8bbe4",
    "switch_location": "switch0"
  }, {
    "id": "<omitted>a494",
    "port_name": "qsfp0",
    "port_settings_id": "<omitted>6760",
    "rack_id": "51becb40-1818-4ea0-b278-2af26bc8bbe4",
    "switch_location": "switch0"
  }, {
    "id": "<omitted>f319",
    "port_name": "qsfp0",
    "port_settings_id": "<omitted>1775",
    "rack_id": "51becb40-1818-4ea0-b278-2af26bc8bbe4",
    "switch_location": "switch1"
  }, {
    "id": "<omitted>a6e1",
    "port_name": "qsfp1",
    "rack_id": "51becb40-1818-4ea0-b278-2af26bc8bbe4",
    "switch_location": "switch1"
  }

[bnaecker]

This appears to be because the actual switch table itself is empty. On Dogfood:

root@[fd00:1122:3344:107::3]:32221/omicron> select * from switch;


Time: 1ms total (execution 1ms / network 0ms)

The method for inserting records in the omicron.public.switch table is here:

omicron/nexus/db-queries/src/db/datastore/switch.rs

Line 21 in 69de8b6

pub async fn switch_upsert(&self, switch: Switch) -> CreateResult<Switch> {

which is called from Nexus::switch_upsert() here:

omicron/nexus/src/app/switch.rs

Lines 28 to 41 in 69de8b6

	pub(crate) async fn switch_upsert(
	&self,
	id: Uuid,
	request: SwitchPutRequest,
	) -> Result<Switch, Error> {
	let switch = db::model::Switch::new(
	id,
	request.baseboard.serial,
	request.baseboard.part,
	request.baseboard.revision,
	request.rack_id,
	);
	self.db_datastore.switch_upsert(switch).await
	}

which is called from Nexus's internal API operation, switch_put here:

omicron/nexus/src/internal_api/http_entrypoints.rs

Lines 160 to 172 in 69de8b6

	async fn switch_put(
	rqctx: RequestContext<Self::Context>,
	path_params: Path<SwitchPathParam>,
	body: TypedBody<SwitchPutRequest>,
	) -> Result<HttpResponseOk<SwitchPutResponse>, HttpError> {
	let apictx = &rqctx.context().context;
	let handler = async {
	let nexus = &apictx.nexus;
	let path = path_params.into_inner();
	let switch = body.into_inner();
	nexus.switch_upsert(path.switch_id, switch).await?;
	Ok(HttpResponseOk(SwitchPutResponse {}))
	};

So far as I can tell, nothing in Omicron calls that endpoint at all, and so we end up with an empty table.

For context, this came up in my attempts to address #6939.