From 19bf75a817a3ae8b6a68d9cde6787e1e3f89d380 Mon Sep 17 00:00:00 2001 From: Will Chandler Date: Mon, 6 Oct 2025 08:46:30 -0400 Subject: [PATCH] Don't create unnecessary SP dump dirs Currently we create a support bundle directory for SP dumps for each component queried, regardless of whether it has any dumps to collect. Create this directory only when needed. --- nexus/src/app/background/tasks/support_bundle_collector.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/nexus/src/app/background/tasks/support_bundle_collector.rs b/nexus/src/app/background/tasks/support_bundle_collector.rs index e1ebc02e95f..df402702c44 100644 --- a/nexus/src/app/background/tasks/support_bundle_collector.rs +++ b/nexus/src/app/background/tasks/support_bundle_collector.rs @@ -1389,6 +1389,10 @@ async fn save_sp_dumps( .context("failed to get task dump count from SP")? .into_inner(); + if dump_count == 0 { + return Ok(()); + } + let output_dir = sp_dumps_dir.join(format!("{}_{}", sp.type_, sp.slot)); tokio::fs::create_dir_all(&output_dir).await?;