Reject changes to system target release version if an update is in progress... #9188
+408
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogress ... unless a mupdate has occurred, in which case we allow it. Fixes #8056.
|
This definitely needs some testing on a racklette before merging, but I believe implements what we decided to do for R17. |
karencfv
reviewed
Oct 13, 2025
Comment on lines
+292
to
+294
| // Convert this to a string; comparing "system version as a string" to | ||
| // "artifact version as a string" below feels bad, but is maybe fine? The | ||
| // artifact versions are loaded from the DB by joining |
There was a problem hiding this comment.
It seems like this part of the comment should be above let current_target_version = current_target_version.to_string(); and there should be additional text after "... from the DB by joining"?
| &bp, | ||
| ¤t_target_version | ||
| )); | ||
| } |
There was a problem hiding this comment.
I think you need a logctx.cleanup_successful(); at the end of this test
Comment on lines
+393
to
+394
| // * We don't keep the desired state of all Hubris components in the | ||
| // blueprint anyway. |
There was a problem hiding this comment.
Not for this PR, but is this something we should have? It feels a little dangerous to not have any kind of ongoing update check for the Hubris components. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... unless a mupdate has occurred, in which case we allow it.
Fixes #8056.