Skip to content

Commit 20272d2

Browse files
authored
misc: downgrade indirect dependency (#128)
After #122 this project would fail to build with the following error. ``` > go build . # k8s.io/apimachinery/pkg/util/managedfields/internal ../../.local/gopath/pkg/mod/k8s.io/[email protected]/pkg/util/managedfields/internal/typeconverter.go:51:61: cannot use typeSchema.Types (variable of type []"sigs.k8s.io/structured-merge-diff/v6/schema".TypeDef) as []"sigs.k8s.io/structured-merge-diff/v4/schema".TypeDef value in struct literal ``` Yes, I know we need CI/CD. It's coming! I ran `go mod graph` and noticed that all packages used `sigs.k8s.io/structured-merge-diff/v4` except for `k8s.io/kube-openapi` which used `sigs.k8s.io/structured-merge-diff/v6`. ``` > go mod graph k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] k8s.io/[email protected] sigs.k8s.io/structured-merge-diff/[email protected] ``` I downgraded `k8s.io/kube-openapi` to the commit just before it upgraded to `sigs.k8s.io/structured-merge-diff/v6`. ``` > go get -u k8s.io/kube-openapi@9bd5c66d9911c53f5aedb8595fde9c229ca56703 go: downgraded k8s.io/kube-openapi v0.0.0-20250814151709-d7b6acb124c3 => v0.0.0-20250701173324-9bd5c66d9911 ``` All good now!
1 parent b88acf1 commit 20272d2

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

go.mod

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,11 @@ require (
9999
k8s.io/component-helpers v0.33.4 // indirect
100100
k8s.io/controller-manager v0.33.4 // indirect
101101
k8s.io/kms v0.33.4 // indirect
102-
k8s.io/kube-openapi v0.0.0-20250814151709-d7b6acb124c3 // indirect
102+
k8s.io/kube-openapi v0.0.0-20250701173324-9bd5c66d9911 // indirect
103103
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 // indirect
104104
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 // indirect
105105
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
106106
sigs.k8s.io/randfill v1.0.0 // indirect
107-
sigs.k8s.io/structured-merge-diff/v4 v4.7.0 // indirect
108-
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 // indirect
107+
sigs.k8s.io/structured-merge-diff/v4 v4.6.0 // indirect
109108
sigs.k8s.io/yaml v1.6.0 // indirect
110109
)

go.sum

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,8 @@ k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=
293293
k8s.io/klog/v2 v2.130.1/go.mod h1:3Jpz1GvMt720eyJH1ckRHK1EDfpxISzJ7I9OYgaDtPE=
294294
k8s.io/kms v0.33.4 h1:rvsVglcIFa9WeKk5vd3mBufSG4D5dqponz1Jz5d6FXU=
295295
k8s.io/kms v0.33.4/go.mod h1:C1I8mjFFBNzfUZXYt9FZVJ8MJl7ynFbGgZFbBzkBJ3E=
296-
k8s.io/kube-openapi v0.0.0-20250814151709-d7b6acb124c3 h1:liMHz39T5dJO1aOKHLvwaCjDbf07wVh6yaUlTpunnkE=
297-
k8s.io/kube-openapi v0.0.0-20250814151709-d7b6acb124c3/go.mod h1:UZ2yyWbFTpuhSbFhv24aGNOdoRdJZgsIObGBUaYVsts=
296+
k8s.io/kube-openapi v0.0.0-20250701173324-9bd5c66d9911 h1:gAXU86Fmbr/ktY17lkHwSjw5aoThQvhnstGGIYKlKYc=
297+
k8s.io/kube-openapi v0.0.0-20250701173324-9bd5c66d9911/go.mod h1:GLOk5B+hDbRROvt0X2+hqX64v/zO3vXN7J78OUmBSKw=
298298
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 h1:hwvWFiBzdWw1FhfY1FooPn3kzWuJ8tmbZBHi4zVsl1Y=
299299
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
300300
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 h1:jpcvIRr3GLoUoEKRkHKSmGjxb6lWwrBlJsXc+eUYQHM=
@@ -304,10 +304,8 @@ sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730/go.mod h1:mdzfpAEoE6DHQEN0uh
304304
sigs.k8s.io/randfill v0.0.0-20250304075658-069ef1bbf016/go.mod h1:XeLlZ/jmk4i1HRopwe7/aU3H5n1zNUcX6TM94b3QxOY=
305305
sigs.k8s.io/randfill v1.0.0 h1:JfjMILfT8A6RbawdsK2JXGBR5AQVfd+9TbzrlneTyrU=
306306
sigs.k8s.io/randfill v1.0.0/go.mod h1:XeLlZ/jmk4i1HRopwe7/aU3H5n1zNUcX6TM94b3QxOY=
307-
sigs.k8s.io/structured-merge-diff/v4 v4.7.0 h1:qPeWmscJcXP0snki5IYF79Z8xrl8ETFxgMd7wez1XkI=
308-
sigs.k8s.io/structured-merge-diff/v4 v4.7.0/go.mod h1:dDy58f92j70zLsuZVuUX5Wp9vtxXpaZnkPGWeqDfCps=
309-
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 h1:jTijUJbW353oVOd9oTlifJqOGEkUw2jB/fXCbTiQEco=
310-
sigs.k8s.io/structured-merge-diff/v6 v6.3.0/go.mod h1:M3W8sfWvn2HhQDIbGWj3S099YozAsymCo/wrT5ohRUE=
307+
sigs.k8s.io/structured-merge-diff/v4 v4.6.0 h1:IUA9nvMmnKWcj5jl84xn+T5MnlZKThmUW1TdblaLVAc=
308+
sigs.k8s.io/structured-merge-diff/v4 v4.6.0/go.mod h1:dDy58f92j70zLsuZVuUX5Wp9vtxXpaZnkPGWeqDfCps=
311309
sigs.k8s.io/yaml v1.4.0/go.mod h1:Ejl7/uTz7PSA4eKMyQCUTnhZYNmLIl+5c2lQPGR2BPY=
312310
sigs.k8s.io/yaml v1.6.0 h1:G8fkbMSAFqgEFgh4b1wmtzDnioxFCUgTZhlbj5P9QYs=
313311
sigs.k8s.io/yaml v1.6.0/go.mod h1:796bPqUfzR/0jLAl6XjHl3Ck7MiyVv8dbTdyT3/pMf4=

0 commit comments

Comments
 (0)