TypeError(InvalidValue) when generating client

[open-schnick]

Hi there,
i cant get the generation of a crate to work when using the jellyfin-api spec.
According to openapi-generator the spec is not malformed but quite large and messy.

cargo progenitor -i jellyfin-openapi-stable.json -o bindings -n bindings --version 10.11.0
gen fail: TypeError(InvalidValue)
Error: generation experienced errors

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
   1: cargo_progenitor::main
   2: std::sys::backtrace::__rust_begin_short_backtrace
   3: std::rt::lang_start::{{closure}}
   4: std::rt::lang_start_internal
   5: main
   6: <unknown>
   7: __libc_start_main
   8: _start

The stacktrace is also not very helpful but it seems the error comes from the typify crate here

[ahl]

The proximate issue appears to be caused by this invalid schema:

          "TranscodeReasons": {
            "enum": [
              "ContainerNotSupported",
              "VideoCodecNotSupported",
              "AudioCodecNotSupported",
              "SubtitleCodecNotSupported",
              "AudioIsExternal",
              "SecondaryAudioNotSupported",
              "VideoProfileNotSupported",
              "VideoLevelNotSupported",
              "VideoResolutionNotSupported",
              "VideoBitDepthNotSupported",
              "VideoFramerateNotSupported",
              "RefFramesNotSupported",
              "AnamorphicVideoNotSupported",
              "InterlacedVideoNotSupported",
              "AudioChannelsNotSupported",
              "AudioProfileNotSupported",
              "AudioSampleRateNotSupported",
              "AudioBitDepthNotSupported",
              "ContainerBitrateExceedsLimit",
              "VideoBitrateNotSupported",
              "AudioBitrateNotSupported",
              "UnknownVideoStreamInfo",
              "UnknownAudioStreamInfo",
              "DirectPlayError",
              "VideoRangeTypeNotSupported",
              "VideoCodecTagNotSupported",
              "StreamCountExceedsLimit"
            ],
            "type": "array",
            "items": {
              "$ref": "#/components/schemas/TranscodeReason"
            },
            "description": "Gets or sets the transcode reasons."
          }

This schema accepts arrays whose items are each valid #/components/schemas/TranscodeReason. Fine, but the value must also be one of the string values in the enum array. In other words: there is no value that would validate against this schema.

Deleting the erroneous enum (jq 'del(.components.schemas.TranscodingInfo.properties.TranscodeReasons.enum)' jellyfin-openapi-stable.json) then runs into this error:

thread 'main' panicked at progenitor-impl/src/method.rs:2048:23:
not yet implemented: more media types than expected for CreateBackup: 3
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The CreateBackup operation has the following responses block:

        "responses": {
          "200": {
            "description": "Backup created.",
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "#/components/schemas/BackupManifestDto"
                }
              },
              "application/json; profile=\"CamelCase\"": {
                "schema": {
                  "$ref": "#/components/schemas/BackupManifestDto"
                }
              },
              "application/json; profile=\"PascalCase\"": {
                "schema": {
                  "$ref": "#/components/schemas/BackupManifestDto"
                }
              }
            }
          },

Currently progenitor only handles a single media type... especially unfortunate in this case since all the media types are basically the same! So I deleted them all with jq:

$ jq -M 'walk(
  if type == "object" then
    with_entries(select(.key | test("^application/json; profile=\"(CamelCase|PascalCase)\"$") | not))
  else .
  end
)' jellyfin-openapi-stable.json >b.json

And I'm still hitting this:

thread 'main' panicked at progenitor-impl/src/method.rs:2048:23:
not yet implemented: more media types than expected for CreateBackup: 3
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Now on a construction like this:

        "requestBody": {
          "description": "The backup options.",
          "content": {
            "application/json": {
              "schema": {
                "allOf": [
                  {
                    "$ref": "#/components/schemas/BackupOptionsDto"
                  }
                ],
                "description": "Defines the optional contents of the backup archive."
              }
            },
            "text/json": {
              "schema": {
                "allOf": [
                  {
                    "$ref": "#/components/schemas/BackupOptionsDto"
                  }
                ],
                "description": "Defines the optional contents of the backup archive."
              }
            },
            "application/*+json": {
              "schema": {
                "allOf": [
                  {
                    "$ref": "#/components/schemas/BackupOptionsDto"
                  }
                ],
                "description": "Defines the optional contents of the backup archive."
              }
            }
          }
        },

So I ran this:

$ jq -M 'walk(
  if type == "object" and has("content") then
    .content as $c
    | ($c | with_entries(select(.key == "application/json"))) as $filtered
    | if ($filtered | length) > 0
      then .content = $filtered
      else .
      end
  else .
  end
)' b.json >c.json

And it failed here:

gen fail: UnexpectedFormat("invalid schema for text/plain: Item(Schema { schema_data: SchemaData { nullable: false, read_only: false, write_only: false, deprecated: false, external_docs: None, example: None, title: None, description: None, discriminator: None, default: None, extensions: {} }, schema_kind: Type(String(StringType { format: Item(Binary), pattern: None, enumeration: [], min_length: None, max_length: None })) })")
Error: generation experienced errors

In summary, there's the proximate schema bug, and several known issues around multiple media types and unhandled media types.