Make drive id for pdfs optional

Author: augustuswm

rfd-processor/src/context.rs

@@ -273,7 +273,7 @@ impl PdfStorage for PdfStorageCtx {
         if let Some(location) = self.locations.get(0) {
             let req = File {
                 copy_requires_writer_permission: Some(true),
-                drive_id: Some(location.drive_id.to_string()),
+                drive_id: location.drive_id.clone(),
                 parents: Some(vec![location.folder_id.to_string()]),
                 name: Some(filename.to_string()),
                 mime_type: Some("application/pdf".to_string()),
@@ -320,7 +320,7 @@ impl PdfStorage for PdfStorageCtx {
 
 #[derive(Debug)]
 pub struct PdfStorageLocation {
-    pub drive_id: String,
+    pub drive_id: Option<String>,
     pub folder_id: String,
 }
 

rfd-processor/src/main.rs

@@ -74,7 +74,7 @@ pub struct StaticStorageConfig {
 
 #[derive(Debug, Deserialize, Serialize)]
 pub struct PdfStorageConfig {
-    pub drive: String,
+    pub drive: Option<String>,
     pub folder: String,
 }
 

rfd-processor/src/updater/update_pdfs.rs

@@ -96,6 +96,12 @@ impl RfdUpdateAction for UpdatePdfs {
         new: &mut PersistedRfd,
         mode: RfdUpdateMode,
     ) -> Result<RfdUpdateActionResponse, RfdUpdateActionErr> {
+        // TODO: This updater should not upload a new version if there were no material changes to
+        // the RFD. This is slightly tricky as we need to consider the contents of the RFD itself
+        // as well as any external documents that may become embedded in it. It would be great if
+        // we could hash the generated PDF, but from past attempts PDFs generated via asciidoctor-pdf
+        // are not deterministic across systems
+
         let RfdUpdateActionContext { ctx, update, .. } = ctx;
 
         // On each update a PDF is uploaded (possibly overwriting an existing file)