[2/n] add tests for duplicate control plane zones and artifacts

We already have code which ensures that duplicate zones and artifacts are detected. Add tests to exercise these code paths (we're going to hoist them to a higher level in a subsequent commit).

While writing this code, I realized that we don't exit with code 0 when encountering duplicate artifacts. That's not good. I'll fix it in a subsequent commit.

Reviewers: iliana

Reviewed By: iliana

Pull Request: #18

Author: sunshowers

bin/invalid-manifests/duplicate-artifact.toml

@@ -0,0 +1,14 @@
+# This manifest contains two artifacts with the same name and version, which
+# will hash to the same value.
+
+system_version = "1.0.0"
+
+[[artifact.gimlet_sp]]
+name = "fake-gimlet-sp"
+version = "1.0.0"
+source = { kind = "fake", size = "1MiB" }
+
+[[artifact.gimlet_sp]]
+name = "fake-gimlet-sp"
+version = "1.0.0"
+source = { kind = "fake", size = "1MiB" }

bin/invalid-manifests/duplicate-zone.toml

@@ -0,0 +1,14 @@
+# This manifest has two control plane zones that hash to the same contents. This
+# is not allowed.
+
+system_version = "1.0.0"
+
+[[artifact.control_plane]]
+name = "fake-control-plane"
+version = "1.0.0"
+[artifact.control_plane.source]
+kind = "composite-control-plane"
+zones = [
+    { kind = "fake", name = "zone1", size = "1MiB" },
+    { kind = "fake", name = "zone1", size = "1MiB" },
+]

bin/tests/integration-tests/command_tests.rs

@@ -223,6 +223,66 @@ fn test_assemble_fake_non_semver() -> Result<()> {
     Ok(())
 }
 
+#[test]
+fn test_assemble_duplicate_zone() -> Result<()> {
+    let log_config = ConfigLogging::File {
+        level: ConfigLoggingLevel::Trace,
+        path: "UNUSED".into(),
+        if_exists: ConfigLoggingIfExists::Fail,
+    };
+    let logctx = LogContext::new("test_assemble_duplicate_zone", &log_config);
+    let tempdir = tempfile::tempdir().unwrap();
+    let key = Key::generate_ed25519()?;
+
+    let archive_path = tempdir.path().join("archive.zip");
+
+    let mut cmd = make_cmd(&key);
+    cmd.args([
+        "assemble",
+        "--skip-all-present",
+        "invalid-manifests/duplicate-zone.toml",
+    ]);
+    cmd.arg(&archive_path);
+    cmd.assert().failure().stderr(predicate::str::contains(
+        "duplicate zones are not allowed \
+         (zone1.tar.gz and zone1.tar.gz have the same checksum)",
+    ));
+
+    logctx.cleanup_successful();
+    Ok(())
+}
+
+#[test]
+fn test_assemble_duplicate_artifact() -> Result<()> {
+    let log_config = ConfigLogging::File {
+        level: ConfigLoggingLevel::Trace,
+        path: "UNUSED".into(),
+        if_exists: ConfigLoggingIfExists::Fail,
+    };
+    let logctx =
+        LogContext::new("test_assemble_duplicate_artifact", &log_config);
+    let tempdir = tempfile::tempdir().unwrap();
+    let key = Key::generate_ed25519()?;
+
+    let archive_path = tempdir.path().join("archive.zip");
+
+    let mut cmd = make_cmd(&key);
+    cmd.args([
+        "assemble",
+        "--skip-all-present",
+        "invalid-manifests/duplicate-artifact.toml",
+    ]);
+    cmd.arg(&archive_path);
+    // TODO: this should be failure, not success!
+    cmd.assert().success().stderr(predicate::str::contains(
+        "a target named gimlet_sp-fake-gimlet-sp-1.0.0.tar.gz \
+         already exists in the repository",
+    ));
+
+    logctx.cleanup_successful();
+    Ok(())
+}
+
 fn make_cmd(key: &Key) -> Command {
     let mut cmd = Command::cargo_bin("tufaceous").unwrap();
     cmd.env("TUFACEOUS_KEY", key.to_string());