Update rb-sys, rb-sys-build, and rb-sys-tests to version 0.9.124

Author: ianks

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "rb-sys-build"
-version = "0.9.123"
+version = "0.9.124"
 edition = "2018"
 description = "Build system for rb-sys"
 homepage = "https://github.com/oxidize-rb/rb-sys"

crates/rb-sys-build/Cargo.toml

@@ -140,7 +140,7 @@ fn clean_docs(rbconfig: &RbConfig, syntax: &mut syn::File) {
     })
 }
 
-fn default_bindgen(clang_args: Vec<String>, rbconfig: &RbConfig) -> bindgen::Builder {
+fn default_bindgen(clang_args: Vec<String>, _rbconfig: &RbConfig) -> bindgen::Builder {
     // Disable layout tests and Debug impl on Windows MinGW due to packed struct layout incompatibilities
     let is_windows_mingw = cfg!(target_os = "windows") && !is_msvc();
 

crates/rb-sys-build/src/bindings.rs

@@ -1,6 +1,6 @@
 [package]
 name = "rb-sys-tests"
-version = "0.9.123"
+version = "0.9.124"
 edition = "2018"
 autotests = false
 publish = false

crates/rb-sys-tests/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 build = "build/main.rs"
 name = "rb-sys"
-version = "0.9.123"
+version = "0.9.124"
 edition = "2018"
 readme = "readme.md"
 categories = ["external-ffi-bindings"]
@@ -14,7 +14,7 @@ repository = "https://github.com/oxidize-rb/rb-sys"
 rust-version = "1.71"
 
 [build-dependencies]
-rb-sys-build = { version = "0.9.123", path = "../rb-sys-build" }
+rb-sys-build = { version = "0.9.124", path = "../rb-sys-build" }
 
 [dev-dependencies]
 rb-sys = { path = ".", features = ["link-ruby"] }

crates/rb-sys/Cargo.toml

@@ -36,7 +36,7 @@ use std::os::raw::{c_char, c_long};
 /// ```
 #[inline(always)]
 pub fn TEST(obj: VALUE) -> bool {
-    api().rb_test(obj.into())
+    api().rb_test(obj)
 }
 
 /// Checks if the given object is nil.
@@ -55,7 +55,7 @@ pub fn TEST(obj: VALUE) -> bool {
 /// ```
 #[inline(always)]
 pub fn NIL_P(obj: VALUE) -> bool {
-    api().nil_p(obj.into())
+    api().nil_p(obj)
 }
 
 /// Checks if the given object is a so-called Fixnum.
@@ -66,7 +66,7 @@ pub fn NIL_P(obj: VALUE) -> bool {
 /// - @note       Fixnum was  a thing  in the  20th century, but  it is  rather an implementation detail today.
 #[inline(always)]
 pub fn FIXNUM_P(obj: VALUE) -> bool {
-    api().fixnum_p(obj.into())
+    api().fixnum_p(obj)
 }
 
 /// Checks if the given object is a static symbol.
@@ -79,7 +79,7 @@ pub fn FIXNUM_P(obj: VALUE) -> bool {
 /// - @note       These days  there are static  and dynamic symbols, just  like we once had Fixnum/Bignum back in the old days.
 #[inline(always)]
 pub fn STATIC_SYM_P(obj: VALUE) -> bool {
-    api().static_sym_p(obj.into())
+    api().static_sym_p(obj)
 }
 
 /// Get the backend storage of a Ruby array.
@@ -95,7 +95,7 @@ pub fn STATIC_SYM_P(obj: VALUE) -> bool {
 /// - @return     Its backend storage.
 #[inline(always)]
 pub unsafe fn RARRAY_CONST_PTR(obj: VALUE) -> *const VALUE {
-    api().rarray_const_ptr(obj.into())
+    api().rarray_const_ptr(obj)
 }
 
 /// Get the length of a Ruby array.
@@ -109,7 +109,7 @@ pub unsafe fn RARRAY_CONST_PTR(obj: VALUE) -> *const VALUE {
 /// - @return     Its length.
 #[inline(always)]
 pub unsafe fn RARRAY_LEN(obj: VALUE) -> c_long {
-    api().rarray_len(obj.into())
+    api().rarray_len(obj)
 }
 
 /// Get the length of a Ruby string.
@@ -123,21 +123,23 @@ pub unsafe fn RARRAY_LEN(obj: VALUE) -> c_long {
 /// - @return     Its length.
 #[inline(always)]
 pub unsafe fn RSTRING_LEN(obj: VALUE) -> c_long {
-    api().rstring_len(obj.into())
+    api().rstring_len(obj)
 }
 
 /// Get the backend storage of a Ruby string.
 ///
 /// ### Safety
 ///
 /// This function is unsafe because it dereferences a raw pointer and returns
-/// raw pointers to Ruby memory.
+/// raw pointers to Ruby memory. The caller must ensure that the pointer stays live
+/// for the duration of usage the the underlying array (by either GC marking or
+/// keeping the RArray on the stack).
 ///
 /// - @param[in]  a  An object of ::RString.
 /// - @return     Its backend storage
 #[inline(always)]
 pub unsafe fn RSTRING_PTR(obj: VALUE) -> *const c_char {
-    api().rstring_ptr(obj.into())
+    api().rstring_ptr(obj)
 }
 
 /// Checks if the given object is a so-called Flonum.
@@ -150,7 +152,7 @@ pub unsafe fn RSTRING_PTR(obj: VALUE) -> *const c_char {
 ///             once had Fixnum/Bignum back in the old days.
 #[inline(always)]
 pub fn FLONUM_P(obj: VALUE) -> bool {
-    api().flonum_p(obj.into())
+    api().flonum_p(obj)
 }
 
 /// Checks if  the given  object is  an immediate  i.e. an  object which  has no
@@ -163,7 +165,7 @@ pub fn FLONUM_P(obj: VALUE) -> bool {
 /// @note       The concept of "immediate" is purely C specific.
 #[inline(always)]
 pub fn IMMEDIATE_P(obj: VALUE) -> bool {
-    api().immediate_p(obj.into())
+    api().immediate_p(obj)
 }
 
 /// Checks if the given object is of enum ::ruby_special_consts.
@@ -183,7 +185,7 @@ pub fn IMMEDIATE_P(obj: VALUE) -> bool {
 /// ```
 #[inline(always)]
 pub fn SPECIAL_CONST_P(obj: VALUE) -> bool {
-    api().special_const_p(obj.into())
+    api().special_const_p(obj)
 }
 
 /// Queries the type of the object.
@@ -404,6 +406,10 @@ pub unsafe fn SYM2ID(obj: VALUE) -> crate::ID {
 }
 
 /// Alias for SYM2ID for compatibility with Ruby naming conventions.
+///
+/// # Safety
+/// - `obj` must be a valid Symbol VALUE
+/// - For dynamic symbols, this may access the heap
 #[inline(always)]
 pub unsafe fn RB_SYM2ID(obj: VALUE) -> crate::ID {
     api().sym2id(obj)

crates/rb-sys/src/macros.rs

@@ -367,7 +367,7 @@ impl StableApiDefinition for Definition {
     #[inline]
     fn fixable(&self, val: std::os::raw::c_long) -> bool {
         // Check if value is within Fixnum range
-        val >= crate::special_consts::FIXNUM_MIN && val <= crate::special_consts::FIXNUM_MAX
+        (crate::special_consts::FIXNUM_MIN..=crate::special_consts::FIXNUM_MAX).contains(&val)
     }
 
     #[inline]

crates/rb-sys/src/stable_api/ruby_4_0.rs

@@ -1,11 +1,11 @@
 [package]
 name = "rust_reverse"
-version = "0.9.123"
+version = "0.9.124"
 autotests = true      # set true if you want to use "cargo test"
 edition = "2018"
 
 [dependencies]
-rb-sys = { version = "0.9.123", path = "./../../../../crates/rb-sys", features = [
+rb-sys = { version = "0.9.124", path = "./../../../../crates/rb-sys", features = [
   "global-allocator",
 ] }
 

examples/rust_reverse/ext/rust_reverse/Cargo.toml

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RustReverse
-  VERSION = "0.9.123"
+  VERSION = "0.9.124"
 end

examples/rust_reverse/lib/rust_reverse/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RbSys
-  VERSION = "0.9.123"
+  VERSION = "0.9.124"
 end