Fix MegaLinter build issue (#2539)

* Add comments in npm install instructions

* [MegaLinter] Apply linters fixes

* Deactivate npm audit fix

* [MegaLinter] Apply linters fixes

* Build

* Typo

* trvy

---------

Co-authored-by: nvuillam <[email protected]>

Author: nvuillam

.automation/build.py

@@ -473,9 +473,13 @@ def build_dockerfile(
             + "RUN npm --no-cache install --ignore-scripts --omit=dev \\\n                "
             + " \\\n                ".join(list(dict.fromkeys(npm_packages)))
             + "  && \\\n"
-            + "       npm audit fix --audit-level=critical || true \\\n"
+            #    + '       echo "Fixing audit issues with npm..." \\\n'
+            #    + "    && npm audit fix --audit-level=critical || true \\\n" # Deactivated for now
+            + '    echo "Cleaning npm cache..." \\\n'
             + "    && npm cache clean --force || true \\\n"
+            + '    && echo "Changing owner of node_modules files..." \\\n'
             + '    && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \\\n'
+            + '    && echo "Removing extra node_module files..." \\\n'
             + "    && rm -rf /root/.npm/_cacache \\\n"
             + '    && find . -name "*.d.ts" -delete \\\n'
             + '    && find . -name "*.map" -delete \\\n'

.trivyignore

@@ -157,6 +157,7 @@ CVE-2022-42889
 CVE-2022-43680
 CVE-2022-46175
 CVE-2023-0286
+CVE-2023-29017
 DS001
 DS002
 DS003

Dockerfile

@@ -241,9 +241,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 prettyjson \
                 @typescript-eslint/eslint-plugin \
                 @typescript-eslint/parser  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/ci_light/Dockerfile

@@ -115,9 +115,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 secretlint \
                 @secretlint/secretlint-rule-preset-recommend \
                 @secretlint/secretlint-formatter-sarif  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/cupcake/Dockerfile

@@ -201,9 +201,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 prettyjson \
                 @typescript-eslint/eslint-plugin \
                 @typescript-eslint/parser  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/documentation/Dockerfile

@@ -146,9 +146,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 cspell \
                 sql-lint \
                 tekton-lint  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/dotnet/Dockerfile

@@ -166,9 +166,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 cspell \
                 sql-lint \
                 tekton-lint  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/go/Dockerfile

@@ -153,9 +153,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 cspell \
                 sql-lint \
                 tekton-lint  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/java/Dockerfile

@@ -146,9 +146,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 cspell \
                 sql-lint \
                 tekton-lint  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \

flavors/javascript/Dockerfile

@@ -166,9 +166,11 @@ RUN npm --no-cache install --ignore-scripts --omit=dev \
                 prettyjson \
                 @typescript-eslint/eslint-plugin \
                 @typescript-eslint/parser  && \
-       npm audit fix --audit-level=critical || true \
+    echo "Cleaning npm cache..." \
     && npm cache clean --force || true \
+    && echo "Changing owner of node_modules files..." \
     && chown -R "$(id -u)":"$(id -g)" node_modules # fix for https://github.com/npm/cli/issues/5900 \
+    && echo "Removing extra node_module files..." \
     && rm -rf /root/.npm/_cacache \
     && find . -name "*.d.ts" -delete \
     && find . -name "*.map" -delete \