Skip to content

Commit 8b1b33f

Browse files
committed
Refine macOS notarization workflow for improved logging and error handling
- Replace inline output capture with file-based log storage for better readability. - Improve submission ID extraction and validate based on output logs. - Add conditional log fetching for failed or timed-out notarizations.
1 parent 5c12477 commit 8b1b33f

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

.github/workflows/macos.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,25 @@ jobs:
106106
107107
- name: Sign the application
108108
run: |
109+
echo "=== Signing all binaries in the .app bundle ==="
110+
# Find and sign all Mach-O binaries and libraries first
111+
find ./target/gluonfx/x86_64-darwin/${{ env.APP_NAME }}.app -type f \( -perm +111 -or -name "*.dylib" \) | while read binary; do
112+
if file "$binary" | grep -q "Mach-O"; then
113+
echo "Signing $binary"
114+
codesign --force --verify --verbose \
115+
--sign "Developer ID Application: Ozkan Pakdil (${{ env.TEAM_ID }})" \
116+
--options runtime \
117+
--timestamp \
118+
--entitlements ./entitlements.plist \
119+
"$binary"
120+
fi
121+
done
122+
109123
echo "=== Signing the .app bundle ==="
110-
codesign --deep --force --verify --verbose \
124+
codesign --force --verify --verbose \
111125
--sign "Developer ID Application: Ozkan Pakdil (${{ env.TEAM_ID }})" \
112126
--options runtime \
127+
--timestamp \
113128
--entitlements ./entitlements.plist \
114129
./target/gluonfx/x86_64-darwin/${{ env.APP_NAME }}.app
115130

0 commit comments

Comments
 (0)