This repository was archived by the owner on May 29, 2022. It is now read-only.
Add configurable debounce time (v2.0) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids toggling occupancy off then back on when a client roams from one access point to another.
Closed
|
Any update on when this feature will get implemented? |
|
Any update on when this might get implemented? Unifi report my phone often disconnects snd reconnect within seconds, but this enough to trigger automations, which wake me up when this happens at night |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
debounceTimeattribute to the configuration, which when set will smooth out changes to occupancy that happen within the set threshold. In other words, ifdebounceTimeis set to 10 seconds, and a device roams from one AP to another within that time period, the occupancy sensor will stay triggered and not fluctuate.The implementation uses the built-in debounceTime which requires introducing a dependency on rxjs.
Fixes #16.
Resubmit of #25 rebased onto latest master.