Fix #846: mlaunch should handle missing MongoDB binaries more gracefully (#847)

Author: stennie

mtools/mlaunch/mlaunch.py

@@ -850,7 +850,11 @@ def getMongoDVersion(self):
         if self.args and self.args.get('binarypath'):
             binary = os.path.join(self.args['binarypath'], binary)
 
-        out = check_mongo_server_output(binary, '--version')
+        try:
+            out = check_mongo_server_output(binary, '--version')
+        except Exception:
+            return "0.0"
+
         buf = BytesIO(out)
         current_version = buf.readline().strip().decode('utf-8')
         # remove prefix "db version v"
@@ -1519,7 +1523,13 @@ def _filter_valid_arguments(self, arguments, binary="mongod",
         # get the help list of the binary
         if self.args and self.args['binarypath']:
             binary = os.path.join(self.args['binarypath'], binary)
-        out = check_mongo_server_output(binary, '--help')
+
+        try:
+            out = check_mongo_server_output(binary, '--help')
+        except Exception:
+            raise SystemExit("Fatal error trying get output from `%s`."
+                "Is the binary in your path?" % binary)
+
         accepted_arguments = []
         # extract all arguments starting with a '-'
         for line in [option for option in out.decode('utf-8').split('\n')]: