refactor: ssprintf logging

Author: ThisAMJ

src/Features/PlayerTrace.cpp

@@ -164,8 +164,8 @@ void PlayerTrace::AddPoint(std::string trace_name, void *player, int slot, bool
 		camera->GetEyePos<true>(slot, eyepos, angles);
 	}
 
-	this->EmitLog(Utils::ssprintf("ProcessMovement(%d)", session->GetTick()).c_str());
-	this->EmitLog(Utils::ssprintf("player @ (%.6f,%.6f,%.6f)", pos.x, pos.y, pos.z).c_str());
+	this->EmitLog("ProcessMovement(%d) slot: %d", session->GetTick(), slot);
+	this->EmitLog("player %d @ (%.6f,%.6f,%.6f)", slot, pos.x, pos.y, pos.z);
 
 	HitboxList hitboxes = ConstructHitboxList(pos);
 
@@ -1215,7 +1215,7 @@ void PlayerTrace::ExitLogScope() {
 	trace->log_scope_stack.pop_back();
 }
 
-void PlayerTrace::EmitLog(const char *msg) {
+void PlayerTrace::EmitLog(std::string msg) {
 	if (!playerTrace->ShouldRecord()) return;
 	auto trace = this->GetTrace(sar_trace_record.GetString());
 	if (!trace) return;
@@ -1227,3 +1227,17 @@ void PlayerTrace::EmitLog(const char *msg) {
 	line += msg;
 	trace->log_lines.push_back(line);
 }
+
+void PlayerTrace::EmitLog(const char *fmt, ...) {
+	va_list ap1, ap2;
+	va_start(ap1, fmt);
+	va_copy(ap2, ap1);
+	size_t sz = vsnprintf(NULL, 0, fmt, ap1) + 1;
+	va_end(ap1);
+	char *buf = (char *)malloc(sz);
+	vsnprintf(buf, sz, fmt, ap2);
+	va_end(ap2);
+	std::string str(buf);
+	free(buf);
+	PlayerTrace::EmitLog(str);
+}

src/Features/PlayerTrace.hpp

@@ -116,7 +116,8 @@ class PlayerTrace : public Feature {
 	// Returns an identifier for the scope which should be passed to ExitLogScope
 	void EnterLogScope(const char *name);
 	void ExitLogScope();
-	void EmitLog(const char *msg);
+	void EmitLog(std::string msg);
+	void EmitLog(const char *fmt, ...);
 };
 
 extern PlayerTrace *playerTrace;

src/Features/RNGManip.cpp

@@ -219,7 +219,7 @@ void RngManip::viewPunch(QAngle *offset) {
 	}
 
 	g_recorded_view_punches.push_back(*offset);
-	playerTrace->EmitLog(Utils::ssprintf("ViewPunch(%.6f, %.6f, %.6f) -> (%.6f, %.6f, %.6f)", orig.x, orig.y, orig.z, offset->x, offset->y, offset->z).c_str());
+	playerTrace->EmitLog("ViewPunch(%.6f, %.6f, %.6f) -> (%.6f, %.6f, %.6f)", orig.x, orig.y, orig.z, offset->x, offset->y, offset->z);
 }
 
 void RngManip::randomSeed(int *seed) {
@@ -230,7 +230,7 @@ void RngManip::randomSeed(int *seed) {
 	}
 
 	g_recorded_randomseeds.push_back(*seed);
-	playerTrace->EmitLog(Utils::ssprintf("RandomSeed(%d) -> %d", orig, *seed).c_str());
+	playerTrace->EmitLog("RandomSeed(%d) -> %d", orig, *seed);
 }
 
 CON_COMMAND(sar_rng_save, "sar_rng_save [filename] - save RNG seed data to the specified file. If filename isn't given, use last TAS script path\n") {