refactor: some small improvements

havent addressed krzy's problem yet

Author: ThisAMJ

src/InstanceIdentifier.cpp

@@ -15,6 +15,8 @@
 #include <unistd.h>
 #endif
 
+#define MAX_INSTANCES 128
+
 
 std::string getInstanceLockFilePath(int index) {
 	std::string tempDir = std::filesystem::temp_directory_path().string();
@@ -93,7 +95,6 @@ void freeInstanceID() {
 int g_instanceID = -1;
 
 void InstanceIdentifier::Claim() {
-	const int MAX_INSTANCES = 128;
 	for (int i = 0; i < MAX_INSTANCES; i++) {
 		if (!tryClaimInstanceID(i)) {
 			continue;
@@ -111,4 +112,4 @@ int InstanceIdentifier::GetID() {
 void InstanceIdentifier::Free() {
 	freeInstanceID();
 	g_instanceID = -1;
-}
+}

src/InstanceIdentifier.hpp

@@ -4,4 +4,4 @@ namespace InstanceIdentifier {
 	void Claim();
 	void Free();
 	int GetID();
-}
+}

src/Modules/EngineDemoRecorder.cpp

@@ -365,11 +365,16 @@ void patchDemoHeaderTempFileToBeUnique() {
 	auto uniqueDemoHeaderNamePtr = (unsigned char *)&uniqueDemoHeaderName;
 
 	g_StartupDemoFile_headerNamePatch = new Memory::Patch();
-	auto StartupDemoFile = Memory::Scan(engine->demorecorder->Name(), Offsets::StartupDemoFile);
-	g_StartupDemoFile_headerNamePatch->Execute(StartupDemoFile + Offsets::StartupDemoFile_HeaderName, uniqueDemoHeaderNamePtr, 4);
+	auto StartupDemoFile = Memory::Scan(engine->demorecorder->Name(), Offsets::StartupDemoFile, Offsets::StartupDemoFile_HeaderName);
+	if (StartupDemoFile) {
+		g_StartupDemoFile_headerNamePatch->Execute(StartupDemoFile, uniqueDemoHeaderNamePtr, 4);
+	}
+
 	g_StartupDemoHeader_headerNamePatch = new Memory::Patch();
-	auto StartupDemoHeader = Memory::Scan(engine->demorecorder->Name(), Offsets::StartupDemoHeader);
-	g_StartupDemoHeader_headerNamePatch->Execute(StartupDemoHeader + Offsets::StartupDemoHeader_HeaderName, uniqueDemoHeaderNamePtr, 4);
+	auto StartupDemoHeader = Memory::Scan(engine->demorecorder->Name(), Offsets::StartupDemoHeader, Offsets::StartupDemoHeader_HeaderName);
+	if (StartupDemoHeader) {
+		g_StartupDemoHeader_headerNamePatch->Execute(StartupDemoHeader, uniqueDemoHeaderNamePtr, 4);
+	}
 }
 
 bool EngineDemoRecorder::Init() {