Skip to content

Commit 0ecd7eb

Browse files
committed
feat: visual improvements
- move clear key button away from save to make use more clear - show bind name for keys on hover - use proper symbols for arrows - use "Win" -- vast majority of users on windows, more clear. - bsp -> back, ret -> enter
1 parent 6d8c004 commit 0ecd7eb

File tree

3 files changed

+28
-17
lines changed

3 files changed

+28
-17
lines changed

index.html

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
</div>
3737
<div class="kp-mainbody">
3838
<div class="kp-row">
39-
<span class="key" p2key="`">`</span>
39+
<span class="key" p2key="`">~<br/>`</span>
4040
<span class="key" p2key="1">1</span>
4141
<span class="key" p2key="2">2</span>
4242
<span class="key" p2key="3">3</span>
@@ -49,7 +49,7 @@
4949
<span class="key" p2key="0">0</span>
5050
<span class="key" p2key="-">-</span>
5151
<span class="key" p2key="=">=</span>
52-
<span class="key widekey2" p2key="backspace">Bsp</span>
52+
<span class="key widekey2" p2key="backspace">Back</span>
5353
</div>
5454
<div class="kp-row">
5555
<span class="key widekey1" p2key="tab">Tab</span>
@@ -80,7 +80,7 @@
8080
<span class="key" p2key="l">L</span>
8181
<span class="key" p2key="semicolon">;</span>
8282
<span class="key" p2key="'">'</span>
83-
<span class="key widekey3" p2key="enter">Ret</span>
83+
<span class="key widekey3" p2key="enter">Enter<br/><small>Return</small></span>
8484
</div>
8585
<div class="kp-row">
8686
<span class="key widekey4" p2key="shift">Shift</span>
@@ -98,11 +98,11 @@
9898
</div>
9999
<div class="kp-row">
100100
<span class="key widekey1" p2key="ctrl">Ctrl</span>
101-
<span class="key widekey1" p2key="lwin">Super</span>
101+
<span class="key widekey1" p2key="lwin">Win<br/><small>Super</small></span>
102102
<span class="key widekey1" p2key="alt">Alt</span>
103103
<span class="key widekey5" p2key="space">Space</span>
104104
<span class="key widekey1" p2key="ralt">Alt</span>
105-
<span class="key widekey1" p2key="rwin">Super</span>
105+
<span class="key widekey1" p2key="rwin">Win<br/><small>Super</small></span>
106106
<span class="key widekey1" p2key="rctrl">Ctrl</span>
107107
</div>
108108
</div>
@@ -120,22 +120,22 @@
120120
<div class="kp-row">
121121
<span class="key" p2key="ins">Ins</span>
122122
<span class="key" p2key="home">Hme</span>
123-
<span class="key" p2key="pgup">Pgu</span>
123+
<span class="key" p2key="pgup">Pg🠉</span>
124124
</div>
125125
<div class="kp-row">
126126
<span class="key" p2key="del">Del</span>
127127
<span class="key" p2key="end">End</span>
128-
<span class="key" p2key="pgdn">Pgd</span>
128+
<span class="key" p2key="pgdn">Pg🠋</span>
129129
</div>
130130
</div>
131131
<div class="kp-midpart">
132132
<div class="kp-row">
133-
<span class="key" p2key="uparrow">^</span>
133+
<span class="key" p2key="uparrow">🠉</span>
134134
</div>
135135
<div class="kp-row">
136-
<span class="key" p2key="leftarrow">&lt;</span>
137-
<span class="key" p2key="downarrow">v</span>
138-
<span class="key" p2key="rightarrow">&gt;</span>
136+
<span class="key" p2key="leftarrow">🠈</span>
137+
<span class="key" p2key="downarrow">🠋</span>
138+
<span class="key" p2key="rightarrow">🠊</span>
139139
</div>
140140
</div>
141141
</div>
@@ -170,7 +170,7 @@
170170
<div class="kp-col">
171171
<span class="key" p2key="kp_minus">-</span>
172172
<span class="key tallkey1" p2key="kp_plus">+</span>
173-
<span class="key tallkey1" p2key="kp_enter">Ret</span>
173+
<span class="key tallkey1" p2key="kp_enter">Ent<br/><small>Return</small></span>
174174
</div>
175175
</div>
176176
<div class="kp-mouse">
@@ -352,9 +352,11 @@ <h3>Misc</h3>
352352
<span>
353353
<input type="text" id="bind_saveload_name">
354354
</span>
355-
<button id="reset_bind">Clear</button>
356355
</div>
357356
</div>
357+
<div>
358+
<button id="reset_bind">Clear Key</button>
359+
</div>
358360
</div>
359361
</div>
360362
<div id="links">

keypanel.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ for (let i = 0; i < keys.length; ++i) {
5151
let key_attr = keys[i].attributes.getNamedItem("p2key");
5252
if (key_attr !== null) {
5353
keys[i].classList.add("bindable");
54+
// Add the key name to the title (hover text)
55+
let title = keys[i].attributes.getNamedItem("title")?.value || "";
56+
keys[i].setAttribute("title", `${title}\n${key_attr.value.toUpperCase()}`.trim());
5457
keys[i].addEventListener("click", function() {
5558
if (g_current_selected !== null) {
5659
g_current_selected.classList.remove("selected");

style.css

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,10 @@ main {
174174
cursor: default;
175175
}
176176

177+
.keypanel .key small {
178+
font-size: 0.5em;
179+
}
180+
177181
.keypanel .key.bindable {
178182
background: var(--key-bg-bindable);
179183
}
@@ -246,7 +250,7 @@ main {
246250
justify-content: center;
247251
gap: 30px;
248252
background: var(--panel-bg);
249-
padding: 20px;
253+
padding: 10px;
250254
}
251255

252256
.keybinder .binds > div > div {
@@ -276,16 +280,18 @@ button:hover {
276280
}
277281

278282
#reset_bind {
279-
flex-grow: 1;
280-
margin: 10px;
283+
flex-grow: 0.2;
281284
}
282285

283286
#reset_all {
284287
padding: 30px;
288+
}
289+
290+
#reset_bind, #reset_all {
285291
border: 2px solid var(--key-bg-bound);
286292
}
287293

288-
#reset_all:hover {
294+
#reset_bind:hover, #reset_all:hover {
289295
background: var(--key-bg-bound-hover);
290296
}
291297

0 commit comments

Comments
 (0)