coroutine_handle by_ref changed to by_val for avoiding ub

Author: p5-vbnekit

library/include/p5/lambda/utils/async/future/front+inl.hxx

@@ -140,7 +140,7 @@ auto this_::Type<T>::operator co_await() const noexcept(true) {
         }
 
         inline auto await_suspend(
-            ::std::coroutine_handle<> const &coroutine
+            ::std::coroutine_handle<> coroutine
         ) const noexcept(false) {
             if (context_.subscription) throw parent_::exceptions::BadState{};
             if (context_.instance) throw parent_::exceptions::BadState{};

library/include/p5/lambda/utils/async/task/promise+inl.hxx

@@ -35,7 +35,7 @@ auto final_suspend() noexcept(true) {
         }
 
         inline auto await_suspend(
-            typename Policy::Coroutine const &coroutine
+            typename Policy::Coroutine coroutine
         ) noexcept(true) {
             if (::std::exchange(suspended_, true)) return false;
             if (! coroutine) return false;
@@ -73,7 +73,7 @@ auto initial_suspend() noexcept(true) {
         }
 
         inline auto await_suspend(
-            Coroutine_ const &coroutine
+            Coroutine_ coroutine
         ) noexcept(true) {
             if (coroutine_) return;
             coroutine_.emplace(nullptr);
@@ -185,7 +185,7 @@ auto await_transform(auto &&awaitable) noexcept(false) {
                 }
 
                 inline static auto await_suspend(
-                    ChildCoroutine_ const &coroutine
+                    ChildCoroutine_ coroutine
                 ) noexcept(true) { return coroutine.promise().context_.parent; }
 
                 inline constexpr static auto await_resume() noexcept(true) {}
@@ -226,7 +226,7 @@ auto await_transform(auto &&awaitable) noexcept(false) {
             return false;
         }
 
-        inline auto await_suspend(Coroutine_ const &coroutine) noexcept(false) {
+        inline auto await_suspend(Coroutine_ coroutine) noexcept(false) {
             if (
                 (! coroutine) || coroutine.done()
             ) throw ::std::invalid_argument{"bad coroutine"};
@@ -305,7 +305,7 @@ auto await_transform(auto &&awaitable) noexcept(false) {
         ChildCoroutine_ coroutine;
 
         inline ChildTask_(
-            ChildCoroutine_ const &coroutine
+            ChildCoroutine_ coroutine
         ) noexcept(true): coroutine{coroutine} {}
     };
 

library/include/p5/lambda/utils/async/task/type+inl.hxx

@@ -85,7 +85,7 @@ template <class T> inline auto this_::Type<T>::start() const noexcept(true) {
 }
 
 template <class T> inline this_::Type<T>::Type(
-    ::std::decay_t<decltype(coroutine_)> const &coroutine
+    ::std::decay_t<decltype(coroutine_)> coroutine
 ) noexcept(false): future_{}, coroutine_{coroutine} {
     using Bad_ = ::std::invalid_argument;
     if (! coroutine) throw Bad_{"bad coroutine"};

library/include/p5/lambda/utils/async/task/type.hxx

@@ -35,7 +35,7 @@ private:
 
 public:
     Type() noexcept(true) = default;
-    Type(::std::decay_t<decltype(coroutine_)> const &) noexcept(false);
+    Type(::std::decay_t<decltype(coroutine_)>) noexcept(false);
 
     Type(Type &&) noexcept(true);
     Type(Type const &) noexcept(true);

library/include/p5/lambda/utils/container/pointer+inl.hxx

@@ -126,7 +126,7 @@ auto this_::Type<Interface>::operator co_await() const noexcept(true) {
         }
 
         inline auto await_suspend(
-            ::std::coroutine_handle<> const &coroutine
+            ::std::coroutine_handle<> coroutine
         ) const noexcept(false) {
             if (context_.subscription) throw ::std::logic_error{"bad state"};
             if (await_ready()) {

library/include/p5/lambda/utils/generator+inl.hxx

@@ -269,7 +269,7 @@ this_::Type<T>::operator == (
 }
 
 template <class T> inline constexpr
-this_::Type<T>::Type(parent_::Handle_<T> const &coroutine) noexcept(true):
+this_::Type<T>::Type(parent_::Handle_<T> coroutine) noexcept(true):
     coroutine_{coroutine}
 {
     if (! coroutine_) return;
@@ -293,7 +293,7 @@ auto this_::Type<T>::begin() const noexcept(true) {
 }
 
 template <class T> inline constexpr this_::Type<T>::Type(
-    this_::Handle_<T> const &coroutine
+    this_::Handle_<T> coroutine
 ) noexcept(true): coroutine_{coroutine} {}
 
 template <class T> inline this_::Type<T>::Type::~Type() noexcept(true) {

library/include/p5/lambda/utils/generator.hxx

@@ -183,7 +183,7 @@ template <class T> struct Type final {
         ::std::default_sentinel_t const &
     ) const noexcept(true);
 
-    constexpr explicit Type(Handle_<T> const &coroutine) noexcept(true);
+    constexpr explicit Type(Handle_<T> coroutine) noexcept(true);
 
 private:
     Handle_<T> coroutine_;
@@ -202,7 +202,7 @@ template <class T> struct Type final:
     constexpr auto end() const noexcept(true);
     constexpr auto begin() const noexcept(true);
 
-    constexpr explicit Type(Handle_<T> const &coroutine) noexcept(true);
+    constexpr explicit Type(Handle_<T> coroutine) noexcept(true);
 
     ~Type() noexcept(true);
     constexpr Type() noexcept(true) = default;

library/tests/utils/src/async.cxx

@@ -146,11 +146,11 @@ BOOST_AUTO_TEST_CASE(future_case) {
 
                 inline constexpr static auto initial_suspend() noexcept(true) {
                     return ::std::suspend_never{};
-                };
+                }
 
                 inline constexpr static auto final_suspend() noexcept(true) {
                     return ::std::suspend_always{};
-                };
+                }
 
                 inline auto return_value(Value_ &value) noexcept(true) {
                     pointer_ = &value;
@@ -171,7 +171,7 @@ BOOST_AUTO_TEST_CASE(future_case) {
             inline ~Result_() noexcept(true) { handle_.destroy(); }
 
             inline Result_(
-                ::std::coroutine_handle<promise_type> const &handle
+                ::std::coroutine_handle<promise_type> handle
             ) noexcept(true): handle_{handle} {}
 
         private: