Cleanup: Store number of total digits

pH-7 · pH-7 · commit 18197cc9a8db · 2021-09-29T21:15:14.000+09:30
diff --git a/src/Generator/Passcode.php b/src/Generator/Passcode.php
@@ -14,12 +14,13 @@ class Passcode
     public const DEFAULT_LENGTH = 6;
 
     private const DIGITS = '1234567890';
+    private const TOTAL_DIGITS = 9;
 
     public static function generate(int $length = self::DEFAULT_LENGTH): string
     {
         $code = [];
         for ($amount = 0; $amount < $length; $amount++) {
-            $code[] = self::DIGITS[mt_rand(0, 9)];
+            $code[] = self::DIGITS[mt_rand(0, self::TOTAL_DIGITS)];
         }
 
         return implode($code);

Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,13 @@ class Passcode`
`14`	`14`	`public const DEFAULT_LENGTH = 6;`
`15`	`15`
`16`	`16`	`private const DIGITS = '1234567890';`
	`17`	`+ private const TOTAL_DIGITS = 9;`
`17`	`18`
`18`	`19`	`public static function generate(int $length = self::DEFAULT_LENGTH): string`
`19`	`20`	`{`
`20`	`21`	`$code = [];`
`21`	`22`	`for ($amount = 0; $amount < $length; $amount++) {`
`22`		`- $code[] = self::DIGITS[mt_rand(0, 9)];`
	`23`	`+ $code[] = self::DIGITS[mt_rand(0, self::TOTAL_DIGITS)];`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`return implode($code);`