Merge pull request #3 from open-source-contributions/use_random_int

pH-7 · web-flow · commit cdb4ca74cdb8 · 2022-11-29T21:29:46.000+10:30
Using random_int to generate cryptographic random
diff --git a/src/Generator/Passcode.php b/src/Generator/Passcode.php
@@ -20,7 +20,7 @@ public static function generate(int $length = self::DEFAULT_LENGTH): string
     {
         $code = [];
         for ($amount = 0; $amount < $length; $amount++) {
-            $code[] = self::DIGITS[mt_rand(0, self::TOTAL_DIGITS)];
+            $code[] = self::DIGITS[random_int(0, self::TOTAL_DIGITS)];
         }
 
         return implode($code);

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public static function generate(int $length = self::DEFAULT_LENGTH): string`
`20`	`20`	`{`
`21`	`21`	`$code = [];`
`22`	`22`	`for ($amount = 0; $amount < $length; $amount++) {`
`23`		`- $code[] = self::DIGITS[mt_rand(0, self::TOTAL_DIGITS)];`
	`23`	`+ $code[] = self::DIGITS[random_int(0, self::TOTAL_DIGITS)];`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`return implode($code);`