You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A bit of updates to documentation and readme. Let's merge this last. (#71)
* A bit of updates to documentation and readme. Let's merge this last.
* Update README.md
* Added timezone to dockerfile and use import in getting started docs
to dedupe docker content.
* Added lucide icons to docs. Sneaker icon is a bit is just inlined as
lucide lab does not has a cdn source afaics.
* Update README.md with new demo vid
* Updated logo, but kept the beet only one for favicon (the flask one is too crowded at this size)
* some small fixes.
* added link to relevant macos section
* Bumped changelog v1 with date
---------
Co-authored-by: Sebastian Mohr <sebastian@mohrenclan.de>
@@ -38,7 +39,7 @@ Autotagging music with beets is great. Beets identifies metadata correctly _most
38
39
39
40
However, if you do want a bit more control, things could be more convenient.
40
41
41
-
This is the main idea with beets-flask: For all folders in your inbox, we generate a preview of what beets _would do_ and show you those previews. Then it's easy to go through them and import the correct ones, while falling back to terminal for those that were not to your liking.
42
+
This is the main idea with beets-flask: For all folders in your inbox, we generate a preview of what beets _would do_ and show you those previews. Then it's easy to go through them and import the correct ones, or pick other candidates for those that were not to your liking.
42
43
43
44
<!-- end motivation -->
44
45
@@ -50,8 +51,11 @@ We provide a docker image with the full beeets-flask setup. You can run it with
Copy file name to clipboardExpand all lines: docs/develop/contribution.md
+58-8Lines changed: 58 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,37 +6,41 @@ We are always happy to see new contributors! If small or large, every contributi
6
6
7
7
Some technical knowledge for the following tools is required to get started with the project. If you are not familiar with them, please check out the documentation for each tool and make sure you have them installed.
We recommend using a virtual environment to manage the dependencies.
27
+
26
28
```bash
27
29
cd backend
28
30
pip install -e .[dev]
29
31
```
30
32
31
33
2.2 **Install the dependencies (frontend):**
32
-
We use (pnpm)[https://pnpm.io/] to manage the frontend dependencies. You may use any other package manager.
34
+
We use [pnpm](https://pnpm.io/) to manage the frontend dependencies. You may use any other package manager. On macOS you might want to run this command inside the container ([see here](resources/macos)).
35
+
33
36
```bash
34
37
cd frontend
35
38
pnpm install --frozen-lockfile
36
39
```
37
40
38
41
3.**Run the application in dev mode:**
39
-
Check the docker compose file and edit if necessary.
42
+
Check the docker compose file and edit if necessary.
43
+
40
44
```bash
41
45
cd ../
42
46
# We recommend to create a copy of the docker compose file
@@ -46,6 +50,7 @@ docker compose -f ./docker/docker-compose.dev-local.yaml up --build
46
50
```
47
51
48
52
## Install pre-commit hooks
53
+
49
54
We automatically check for code style and formatting issues using pre-commit hooks. To install the hooks, run the following command (optional):
50
55
51
56
```bash
@@ -78,3 +83,48 @@ pnpm check-types
78
83
## Submitting a Pull Request
79
84
80
85
Fork the repository and create a new branch for your changes. Feel free to follow [this guide](https://docs.github.com/en/get-started/quickstart/contributing-to-projects) for more information on how to create a pull request. Once you are done we will review your changes as soon as possible. Please be patient, as we are a small team and may not be able to review your changes immediately.
We use docker for containerization and deployment of our application. You can find the files needed to build the docker images in the `docker` folder.
3
+
We use docker for containerization and deployment of our application. You can find the files needed to build the docker images in the [`docker`](https://github.com/pSpitzner/beets-flask/tree/main/docker) folder.
4
4
5
5
Redis-Caching seems to be very persistent and we have not figured out how to completely reset it without _rebuilding_ the container.
6
6
Thus, currently, after code changes that run inside a redis worker `docker-compose up --build` is needed even when live-mounting the repo.
7
7
8
-
9
8
## Entrypoints
10
9
11
-
We use different entrypoints for the different environments. You can find all scripts in the `docker/entrypoints` folder.
10
+
We use different entrypoints for the different environments. You can find all scripts in the [`docker/entrypoints`](https://github.com/pSpitzner/beets-flask/tree/main/docker/entrypoints) folder.
0 commit comments