Skip to content

Commit 1ad1e7c

Browse files
authored
Selection state wasn't computed correctly. Splicing does not change (#75)
object reference which does not trigger state update.
1 parent d2bc4e3 commit 1ad1e7c

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

frontend/src/components/inbox/folderSelectionContext.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,12 @@ export function FolderSelectionProvider({ children }: { children: React.ReactNod
4343
if (selected.hashes.includes(folder.hash)) {
4444
const idx = selected.hashes.indexOf(folder.hash);
4545

46-
selected.paths.splice(idx, 1);
47-
selected.hashes.splice(idx, 1);
46+
const newHashes = selected.hashes.filter((_, i) => i !== idx);
47+
const newPaths = selected.paths.filter((_, i) => i !== idx);
48+
4849
return {
49-
hashes: selected.hashes,
50-
paths: selected.paths,
50+
hashes: newHashes,
51+
paths: newPaths,
5152
};
5253
} else {
5354
return {

0 commit comments

Comments
 (0)