fixed a few config loading issues

Author: pSpitzner

backend/beets_flask/config/schema.py

@@ -17,8 +17,10 @@ class BeetsSchema:
     # Besides the beets-flask specific config, we want to ensure type safety
     # for those fields of the native beets config that we use ourself.
     directory: str = field(default="/music/imported")
-    ignore: list[str] = field(default_factory=lambda: [])
-    plugins: list[str] = field(default_factory=lambda: [])
+    ignore: list[str] = field(
+        default_factory=lambda: [".*", "*~", "System Volume Information", "lost+found"]
+    )
+    plugins: list[str] = field(default_factory=lambda: ["musicbrainz"])
 
     # `import` is a reserved keyword in Python. Eyconf's workaround is an alias.
     import_: ImportSection = field(

backend/beets_flask/server/app.py

@@ -4,6 +4,7 @@
 import os
 from dataclasses import asdict, is_dataclass
 from datetime import date, datetime
+from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
 from quart import Quart
@@ -83,4 +84,8 @@ def default(self, o):
         if isinstance(o, Enum):
             return o.value
 
+        # Path to string
+        if isinstance(o, Path):
+            return str(o)
+
         return json.JSONEncoder.default(self, o)

backend/beets_flask/server/routes/library/artists.py

@@ -23,16 +23,14 @@
 # Also artistids are not used, but they are in the database.
 
 
-ARTIST_SEPARATORS: list[str] = get_config().data.gui.library.artist_separators
+def artist_separators() -> list[str]:
+    return get_config().data.gui.library.artist_separators
 
 
-def _split_pattern(separators: list[str]) -> str:
+def split_pattern(separators: list[str]) -> str:
     return "|".join(map(re.escape, separators))
 
 
-ARTIST_SPLIT_PATTERN = _split_pattern(ARTIST_SEPARATORS)
-
-
 def get_artists_polars(table: str, artist: str | None = None) -> pl.LazyFrame:
     """Get all artists from the database using polars.
 
@@ -62,8 +60,10 @@ def get_artists_polars(table: str, artist: str | None = None) -> pl.LazyFrame:
 
     # Split the artist string by the specified separators
     artists: list[str] | None
-    if len(ARTIST_SEPARATORS) > 0 and artist is not None:
-        artists = [a.strip() for a in re.split(ARTIST_SPLIT_PATTERN, artist)]
+    if len(artist_separators()) > 0 and artist is not None:
+        artists = [
+            a.strip() for a in re.split(split_pattern(artist_separators()), artist)
+        ]
     elif artist is not None:
         artists = [artist.strip()]
     else:
@@ -99,14 +99,14 @@ def get_artists_polars(table: str, artist: str | None = None) -> pl.LazyFrame:
     df = df.with_columns((pl.col("added") * 1000).alias("added"))
 
     # Split artist strings into lists and explode into separate rows
-    if len(ARTIST_SEPARATORS) > 0:
+    if len(artist_separators()) > 0:
         # split does not yet support regex...
         # see https://github.com/pola-rs/polars/issues/4819
         # we do a replace workaround
         df = df.with_columns(
             pl.col("artist")
             .str.replace_all("\uffff", "")
-            .str.replace_all(ARTIST_SPLIT_PATTERN, "\uffff")
+            .str.replace_all(split_pattern(artist_separators()), "\uffff")
             .str.split("\uffff")
         ).explode("artist")
 
@@ -122,7 +122,7 @@ def get_artists_polars(table: str, artist: str | None = None) -> pl.LazyFrame:
 
     if artists is not None:
         # If an artist is specified, filter the result
-        pattern = _split_pattern(artists)
+        pattern = split_pattern(artists)
         df = df.filter(pl.col("artist").str.contains(pattern, literal=False))
         # Overwrite if there are multiple artists (i.e. joined by a separator)
         if len(artists) > 1:

backend/tests/integration/test_routes/test_library.py

@@ -135,8 +135,8 @@ async def test_no_separators(self, client: Client):
 
         # Mock artist_seperators
         with mock.patch(
-            "beets_flask.server.routes.library.artists.ARTIST_SEPARATORS",
-            [],
+            "beets_flask.server.routes.library.artists.artist_separators",
+            lambda: [],
         ):
             response = await client.get("/api_v1/library/artists/Foo; Bar")
             data = await response.get_json()