fix some tests and new linter ruff

Author: pablodz

.deepsource.toml

@@ -5,6 +5,3 @@ name = "python"
 
   [analyzers.meta]
   runtime_version = "3.x.x"
-
-[[transformers]]
-name = "black"

.flake8

@@ -12,11 +12,11 @@ jobs:
     strategy:
       matrix:
         python-version:
-          - 3.7
-          - 3.8
-          - 3.9
-          - 3.10.9
           - 3.11
+          - 3.10.9
+          - 3.9
+          - 3.8
+          - 3.7
     # env:
     #   PYTHON_FOR_COVERAGE: "3.9"
     steps:

.github/workflows/build.yml

@@ -1,5 +1,4 @@
 .DEFAULT_GOAL := help
-.PHONY: coverage deps help lint publish push test tox
 
 apt-packages-ubuntu: ## Install packages needed
 	sudo add-apt-repository ppa:pipewire-debian/pipewire-upstream -y
@@ -10,17 +9,6 @@ deps:  ## Install dependencies
 	python -m pip install --upgrade pip
 	python -m pip install black coverage flake8 flit mccabe mypy pylint pytest pytest-cov tox tox-gh-actions
 
-# coverage:  ## Run tests with coverage
-# 	python -m coverage erase
-# 	python -m coverage run --include=pipewire_python/* -m pytest -ra
-# 	python -m coverage report -m
-# 	python -m coverage xml
-
-# lint:  ## Lint and static-check
-# 	python -m flake8 pipewire_python
-# 	python -m pylint pipewire_python
-# 	python -m mypy pipewire_python
-
 publish:  ## Publish to PyPi
 	python -m flit publish
 
@@ -33,3 +21,6 @@ test:  ## Run tests [LOCALHOST]
 tox:  ## Run tox
 	python3 -m tox
 	ls -la
+
+help:
+	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'

.pylintrc

@@ -12,14 +12,16 @@
 for the future of Linux application development.
 
 [pipewire_python](https://pypi.org/project/pipewire_python/) 
-controlls `pipewire` via terminal, creating shell commands and executing them as required.
+controlls `pipewire` via terminal, creating shell commands 
+and executing them as required.
 
 🎹 There are two ways to manage the python package:
 
 1. NO_ASYNC: this way works as expected with delay time between 
 `pipewire_python` and the rest of your code.
 
-2. ASYNC: [⚠️Not yet implemented] this way works delegating the task to record or to play
+2. ASYNC: [⚠️Not yet implemented] this way works delegating
+the task to record or to play
 a song file in background. Works with threads.
 
 3. MULTIPROCESS: [⚠️Not yet implemented] Works with processes.

CHANGELOG.md

@@ -8,7 +8,7 @@
 from typing import Dict, List
 
 # Loading constants Constants.py
-from ._constants import MESSAGES_ERROR
+from pipewire_python._constants import MESSAGES_ERROR
 
 
 def _print_std(
@@ -57,7 +57,9 @@ def _update_dict_by_dict(
     Update values of one dictionary with values of another dictionary
     based on keys
     """
-    return main_dict.update(([(key, secondary_dict[key]) for key in secondary_dict.keys()]))
+    return main_dict.update(
+        ([(key, secondary_dict[key]) for key in secondary_dict.keys()])
+    )
 
 
 def _drop_keys_with_none_values(main_dict: dict):

Makefile

@@ -5,10 +5,17 @@
 `controller.py`.
 """
 
-import warnings
+# import warnings
+
+# Loading constants Constants.py
+from pipewire_python._constants import (
+    MESSAGES_ERROR,
+    RECOMMENDED_FORMATS,
+    RECOMMENDED_RATES,
+)
 
 # Loading internal functions
-from ._utils import (
+from pipewire_python._utils import (
     _drop_keys_with_none_values,
     _execute_shell_command,
     _filter_by_type,
@@ -18,9 +25,6 @@
     _get_dict_from_stdout,
 )
 
-# Loading constants Constants.py
-from ._constants import MESSAGES_ERROR, RECOMMENDED_FORMATS, RECOMMENDED_RATES
-
 # [DEPRECATED] [FLAKE8] TO_AVOID_F401 PEP8
 # [DEPRECATED] https://stackoverflow.com/a/31079085/10491422
 # NOW USED IN DOCUMENTATION
@@ -103,7 +107,9 @@ def __init__(
         # get default parameters with help
         stdout, _ = _execute_shell_command(command=mycommand, verbose=verbose)  # stderr
         # convert stdout to dictionary
-        dict_default_values = _get_dict_from_stdout(stdout=str(stdout.decode()), verbose=verbose)
+        dict_default_values = _get_dict_from_stdout(
+            stdout=str(stdout.decode()), verbose=verbose
+        )
 
         if verbose:
             print(self._pipewire_configs)
@@ -164,7 +170,9 @@ def get_version(
         if verbose:
             print(f"[mycommand]{mycommand}")
 
-        stdout, _ = _execute_shell_command(command=mycommand, timeout=-1, verbose=verbose)
+        stdout, _ = _execute_shell_command(
+            command=mycommand, timeout=-1, verbose=verbose
+        )
         versions = stdout.decode().split("\n")[1:]
 
         self._pipewire_cli["--version"] = versions
@@ -311,7 +319,9 @@ def set_config(
         elif target is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[target='{target}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[target='{target}'] EMPTY VALUE"
+            )
         # 5 - latency
         if latency:
             if any(chr.isdigit() for chr in latency):  # Contain numbers
@@ -323,7 +333,9 @@ def set_config(
         elif latency is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[latency='{latency}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[latency='{latency}'] EMPTY VALUE"
+            )
         # 6 - rate
         if rate:
             if rate in RECOMMENDED_RATES:
@@ -336,7 +348,9 @@ def set_config(
         elif rate is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[rate='{rate}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[rate='{rate}'] EMPTY VALUE"
+            )
         # 7 - channels
         if channels:
             if channels in [1, 2]:  # values
@@ -349,7 +363,9 @@ def set_config(
         elif channels is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[channels='{channels}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[channels='{channels}'] EMPTY VALUE"
+            )
         # 8 - channels-map
         if channels_map:
             self._pipewire_configs["--channels-map"] = str(channels_map)
@@ -371,7 +387,9 @@ def set_config(
         elif _format is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[_format='{_format}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[_format='{_format}'] EMPTY VALUE"
+            )
         # 10 - volume
         if volume:
             if 0.0 <= volume <= 1.0:
@@ -384,7 +402,9 @@ def set_config(
         elif volume is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[volume='{volume}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[volume='{volume}'] EMPTY VALUE"
+            )
         # 11 - quality
         if quality:
             if 0 <= quality <= 15:
@@ -396,7 +416,9 @@ def set_config(
         elif quality is None:
             pass
         else:
-            raise ValueError(f"{MESSAGES_ERROR['ValueError']}[volume='{volume}'] EMPTY VALUE")
+            raise ValueError(
+                f"{MESSAGES_ERROR['ValueError']}[volume='{volume}'] EMPTY VALUE"
+            )
 
         # 12 - verbose cli
         if verbose:  # True
@@ -419,13 +441,17 @@ def load_list_targets(
 
         if mode == "playback":
             mycommand = ["pw-cat", "--playback", "--list-targets"]
-            stdout, _ = _execute_shell_command(command=mycommand, timeout=-1, verbose=verbose)
+            stdout, _ = _execute_shell_command(
+                command=mycommand, timeout=-1, verbose=verbose
+            )
             self._pipewire_list_targets["list_playback"] = _generate_dict_list_targets(
                 longstring=stdout.decode(), verbose=verbose
             )
         elif mode == "record":
             mycommand = ["pw-cat", "--record", "--list-targets"]
-            stdout, _ = _execute_shell_command(command=mycommand, timeout=-1, verbose=verbose)
+            stdout, _ = _execute_shell_command(
+                command=mycommand, timeout=-1, verbose=verbose
+            )
             self._pipewire_list_targets["list_record"] = _generate_dict_list_targets(
                 longstring=stdout.decode(), verbose=verbose
             )
@@ -503,10 +529,13 @@ def get_list_interfaces(
         ```
         Args:
             filtered_by_type : If False, returns all. If not, returns a fitered dict
-            type_interfaces : Set type of Interface ["Client","Link","Node","Factory","Module","Metadata","Endpoint","Session","Endpoint Stream","EndpointLink","Port"]
+            type_interfaces : Set type of Interface
+            ["Client","Link","Node","Factory","Module","Metadata","Endpoint",
+            "Session","Endpoint Stream","EndpointLink","Port"]
 
         Returns:
-            - dict_interfaces_filtered: dictionary with list of interfaces matching conditions
+            - dict_interfaces_filtered: dictionary
+            with list of interfaces matching conditions
 
         Examples:
         ```python
@@ -519,8 +548,12 @@ def get_list_interfaces(
         # if verbose:
         #     print(f"[mycommand]{mycommand}")
 
-        stdout, _ = _execute_shell_command(command=mycommand, timeout=-1, verbose=verbose)
-        dict_interfaces = _generate_dict_interfaces(longstring=stdout.decode(), verbose=verbose)
+        stdout, _ = _execute_shell_command(
+            command=mycommand, timeout=-1, verbose=verbose
+        )
+        dict_interfaces = _generate_dict_interfaces(
+            longstring=stdout.decode(), verbose=verbose
+        )
 
         if filtered_by_type:
             dict_interfaces_filtered = _filter_by_type(
@@ -554,16 +587,20 @@ def playback(
             - stdout (`str`): Shell response to the command in stdout format
             - stderr (`str`): Shell response response to the command in stderr format
         """
-        warnings.warn("The name of the function may change on future releases", DeprecationWarning)
+        # warnings.warn("The name of the function may change on future releases", DeprecationWarning)
 
-        mycommand = ["pw-cat", "--playback", audio_filename] + _generate_command_by_dict(
-            mydict=self._pipewire_configs, verbose=verbose
-        )
+        mycommand = [
+            "pw-cat",
+            "--playback",
+            audio_filename,
+        ] + _generate_command_by_dict(mydict=self._pipewire_configs, verbose=verbose)
 
         if verbose:
             print(f"[mycommand]{mycommand}")
 
-        stdout, stderr = _execute_shell_command(command=mycommand, timeout=-1, verbose=verbose)
+        stdout, stderr = _execute_shell_command(
+            command=mycommand, timeout=-1, verbose=verbose
+        )
         return stdout, stderr
 
     def record(
@@ -590,7 +627,7 @@ def record(
             - stdout (`str`): Shell response to the command in stdout format
             - stderr (`str`): Shell response response to the command in stderr format
         """
-        warnings.warn("The name of the function may change on future releases", DeprecationWarning)
+        # warnings.warn("The name of the function may change on future releases", DeprecationWarning)
 
         mycommand = ["pw-cat", "--record", audio_filename] + _generate_command_by_dict(
             mydict=self._pipewire_configs, verbose=verbose