Skip to content

Commit 5d8faf4

Browse files
committed
fixes
1 parent c57a9fc commit 5d8faf4

File tree

5 files changed

+42
-9
lines changed

5 files changed

+42
-9
lines changed
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
package org.pac4j.framework.adapter;
2+
3+
import lombok.val;
4+
import org.pac4j.core.adapter.DefaultFrameworkAdapter;
5+
import org.pac4j.core.config.Config;
6+
import org.pac4j.core.exception.TechnicalException;
7+
import org.pac4j.core.util.CommonHelper;
8+
import org.pac4j.vertx.VertxFrameworkParameters;
9+
import org.pac4j.vertx.VertxWebContext;
10+
import org.pac4j.vertx.context.session.VertxSessionStore;
11+
import org.pac4j.vertx.http.VertxHttpActionAdapter;
12+
13+
/**
14+
* Specific config startup for Vert.x.
15+
*
16+
* @author Jerome LELEU
17+
* @since 7.0.0
18+
*/
19+
public class FrameworkAdapterImpl extends DefaultFrameworkAdapter {
20+
21+
@Override
22+
public void applyDefaultSettingsIfUndefined(final Config config) {
23+
CommonHelper.assertNotNull("config", config);
24+
25+
config.setWebContextFactoryIfUndefined(fp -> new VertxWebContext( ((VertxFrameworkParameters)fp).routingContext() ));
26+
config.setHttpActionAdapterIfUndefined(VertxHttpActionAdapter.INSTANCE);
27+
28+
super.applyDefaultSettingsIfUndefined(config);
29+
}
30+
31+
@Override
32+
public String toString() {
33+
return "Vert.x";
34+
}
35+
}

src/main/java/org/pac4j/vertx/VertxWebContext.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,11 @@ public class VertxWebContext implements WebContext {
3535
private final JsonObject headers;
3636
private final JsonObject parameters;
3737
private final Map<String, String[]> mapParameters;
38-
private final SessionStore sessionStore;
3938

40-
public VertxWebContext(final RoutingContext routingContext, final SessionStore sessionStore) {
39+
public VertxWebContext(final RoutingContext routingContext) {
4140
final HttpServerRequest request = routingContext.request();
4241
this.routingContext = routingContext;
4342
this.method = request.method().toString();
44-
this.sessionStore = sessionStore;
4543

4644
this.fullUrl = request.absoluteURI();
4745
URI uri;

src/main/java/org/pac4j/vertx/handler/impl/CallbackHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import io.vertx.core.Handler;
44
import io.vertx.core.Vertx;
55
import io.vertx.ext.web.RoutingContext;
6+
import lombok.val;
67
import org.pac4j.core.config.Config;
78
import org.pac4j.core.context.session.SessionStore;
89
import org.pac4j.core.engine.CallbackLogic;
@@ -46,8 +47,7 @@ public CallbackHandler(final Vertx vertx,
4647

4748
@Override
4849
public void handle(final RoutingContext rc) {
49-
final CallbackLogic callbackLogic =
50-
(config.getCallbackLogic() != null) ? config.getCallbackLogic() : DefaultCallbackLogic.INSTANCE;
50+
val callbackLogic = config.getCallbackLogic();
5151

5252
vertx.<Void>executeBlocking(() -> {
5353
callbackLogic.perform(

src/main/java/org/pac4j/vertx/handler/impl/LogoutHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import io.vertx.core.Vertx;
55
import io.vertx.ext.web.RoutingContext;
66

7+
import lombok.val;
78
import org.pac4j.core.config.Config;
89
import org.pac4j.core.context.session.SessionStore;
910
import org.pac4j.core.engine.DefaultLogoutLogic;
@@ -58,8 +59,7 @@ public LogoutHandler(final Vertx vertx,
5859

5960
@Override
6061
public void handle(final RoutingContext rc) {
61-
final LogoutLogic logoutLogic =
62-
(config.getCallbackLogic() != null) ? config.getLogoutLogic() : DefaultLogoutLogic.INSTANCE;
62+
val logoutLogic = config.getLogoutLogic();
6363

6464
vertx.<Void>executeBlocking(() -> {
6565
logoutLogic.perform(

src/main/java/org/pac4j/vertx/handler/impl/SecurityHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import io.vertx.ext.web.RoutingContext;
55
import io.vertx.ext.web.handler.AuthenticationHandler;
66
import io.vertx.ext.web.impl.UserContextInternal;
7+
import lombok.val;
78
import org.pac4j.core.config.Config;
89
import org.pac4j.core.context.WebContext;
910
import org.pac4j.core.engine.*;
@@ -38,8 +39,7 @@ public SecurityHandler(final Vertx vertx,
3839

3940
@Override
4041
public void handle(final RoutingContext ctx) {
41-
final SecurityLogic securityLogic =
42-
(config.getSecurityLogic() != null) ? config.getSecurityLogic() : DefaultSecurityLogic.INSTANCE;
42+
val securityLogic = config.getSecurityLogic();
4343

4444
final SecurityGrantedAccessAdapter granted = (context, store, profiles) -> {
4545
final Pac4jUser user = new Pac4jUser(profiles);

0 commit comments

Comments
 (0)