Make sure the unit has length 1

lambdamoses · lambdamoses · commit 3dce17476188 · 2025-02-05T23:42:47.000-05:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: SpatialFeatureExperiment
 Type: Package
 Title: Integrating SpatialExperiment with Simple Features in sf
-Version: 1.9.7
+Version: 1.9.8
 Authors@R: 
     c(person("Lambda", "Moses", email = "dl3764@columbia.edu", 
     role = c("aut", "cre"),
diff --git a/R/SFE-class.R b/R/SFE-class.R
@@ -142,6 +142,7 @@ SpatialFeatureExperiment <- function(assays,
                                      spatialGraphs = NULL,
                                      unit = c("full_res_image_pixel", "micron"),
                                      ...) {
+    unit <- match.arg(unit)
     if (!length(colData)) {
         colData <- make_zero_col_DFrame(nrow = ncol(assays[[1]]))
     }
diff --git a/tests/testthat/test-SFE-class.R b/tests/testthat/test-SFE-class.R
@@ -20,6 +20,7 @@ test_that("Not supplying colGeometries, supplying coordinates in colData", {
         colData = coords1,
         spatialCoordsNames = c("col", "row")
     )
+    expect_equal(unit(sfe), "full_res_image_pixel")
     expect_equal(colGeometryNames(sfe), "centroids")
     expect_equal(as.character(st_geometry_type(colGeometry(sfe),
         by_geometry = FALSE

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ SpatialFeatureExperiment <- function(assays,`
`142`	`142`	`spatialGraphs = NULL,`
`143`	`143`	`unit = c("full_res_image_pixel", "micron"),`
`144`	`144`	`...) {`
	`145`	`+ unit <- match.arg(unit)`
`145`	`146`	`if (!length(colData)) {`
`146`	`147`	`colData <- make_zero_col_DFrame(nrow = ncol(assays[[1]]))`
`147`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ test_that("Not supplying colGeometries, supplying coordinates in colData", {`
`20`	`20`	`colData = coords1,`
`21`	`21`	`spatialCoordsNames = c("col", "row")`
`22`	`22`	`)`
	`23`	`+ expect_equal(unit(sfe), "full_res_image_pixel")`
`23`	`24`	`expect_equal(colGeometryNames(sfe), "centroids")`
`24`	`25`	`expect_equal(as.character(st_geometry_type(colGeometry(sfe),`
`25`	`26`	`by_geometry = FALSE`