Show method name in findSpatialNeighbors error messages that come from methods #72

Author: lambdamoses

R/graph_wrappers.R

@@ -556,18 +556,19 @@ setMethod(
             poly2nb = poly2nb
         )
         if (length(sample_id) == 1L) {
-            out <- .comp_graph_sample(
+            tryCatch(out <- .comp_graph_sample(
                 x, sample_id, type, MARGIN, method,
                 dist_type, args, extra_args_use, glist,
                 style, zero.policy, alpha, dmax, fun_use, return_sf
-            )
+            ), error = function(e) stop(method, ": ", e$message, call. = FALSE))
+            
         } else {
             out <- lapply(sample_id, function(s) {
-                .comp_graph_sample(
+                tryCatch(.comp_graph_sample(
                     x, s, type, MARGIN, method, dist_type,
                     args, extra_args_use, glist, style,
                     zero.policy, alpha, dmax, fun_use, return_sf
-                )
+                ), error = function(e) stop(method, ": ", e$message, call. = FALSE))
             })
             names(out) <- sample_id
         }

tests/testthat/test-graph_wrappers.R

@@ -172,3 +172,12 @@ test_that("Correct Visium HD graph", {
     g <- findVisiumHDGraph(sfe)
     expect_s3_class(g, "listw")
 })
+
+test_that("Show method name in error message", {
+    mat <- matrix(rnorm(9), 3, 3)
+    # Get duplicated coordinates
+    coords <- cbind(c(1,2,1), c(1,2,1))
+    sfe <- SpatialFeatureExperiment(assays = list(counts = mat),
+                                    spatialCoords = coords)
+    expect_error(findSpatialNeighbors(sfe), "tri2nb")
+})