Fix percent encoding and pass original tests

Author: dwalluck

src/main/java/com/github/packageurl/PackageURL.java

@@ -434,11 +434,11 @@ private String canonicalize(boolean coordinatesOnly) {
         }
         purl.append("/");
         if (namespace != null) {
-            purl.append(encodePath(namespace));
+            purl.append(encodePath(namespace, ":"));
             purl.append("/");
         }
         if (name != null) {
-            purl.append(percentEncode(name));
+            purl.append(percentEncode(name, ":"));
         }
         if (version != null) {
             purl.append("@").append(percentEncode(version));
@@ -449,36 +449,44 @@ private String canonicalize(boolean coordinatesOnly) {
                 qualifiers.entrySet().stream().forEachOrdered((entry) -> {
                     purl.append(entry.getKey().toLowerCase());
                     purl.append("=");
-                    purl.append(percentEncode(entry.getValue()));
+                    purl.append(percentEncode(entry.getValue(), ":/"));
                     purl.append("&");
                 });
                 purl.setLength(purl.length() - 1);
             }
             if (subpath != null) {
-                purl.append("#").append(encodePath(subpath));
+                purl.append("#").append(encodePath(subpath, "?#+&="));
             }
         }
         return purl.toString();
     }
 
+    private String percentEncode(final String input, final Charset charset, final String charsToExclude) {
+        return uriEncode(input, charset, charsToExclude);
+    }
+
+    private String percentEncode(final String input, final String charsToExclude) {
+        return percentEncode(input, StandardCharsets.UTF_8, charsToExclude);
+    }
+
     /**
      * Encodes the input in conformance with RFC 3986.
      *
      * @param input the String to encode
      * @return an encoded String
      */
     private String percentEncode(final String input) {
-        return uriEncode(input, StandardCharsets.UTF_8);
+        return percentEncode(input, StandardCharsets.UTF_8, null);
     }
 
-    private static String uriEncode(String source, Charset charset) {
+    private static String uriEncode(String source, Charset charset, String chars) {
         if (source == null || source.length() == 0) {
             return source;
         }
 
         StringBuilder builder = new StringBuilder();
         for (byte b : source.getBytes(charset)) {
-            if (isUnreserved(b)) {
+            if (isUnreserved(b) || chars != null && chars.indexOf(b) != -1) {
                 builder.append((char) b);
             }
             else {
@@ -491,7 +499,7 @@ private static String uriEncode(String source, Charset charset) {
     }
 
     private static boolean isUnreserved(int c) {
-        return (isAlpha(c) || isDigit(c) || '-' == c || '.' == c || '_' == c || '~' == c || ':' == c || '/' == c);
+        return (isAlpha(c) || isDigit(c) || '-' == c || '.' == c || '_' == c || '~' == c);
     }
 
     private static boolean isAlpha(int c) {
@@ -718,8 +726,8 @@ private String[] parsePath(final String value, final boolean isSubpath) throws M
                 .toArray(String[]::new);
     }
 
-    private String encodePath(final String path) {
-        return Arrays.stream(path.split("/")).map(segment -> percentEncode(segment)).collect(Collectors.joining("/"));
+    private String encodePath(final String path, String chars) {
+        return Arrays.stream(path.split("/")).map(segment -> percentEncode(segment, chars)).collect(Collectors.joining("/"));
     }
 
     /**

src/test/resources/test-suite-data.json

@@ -85,8 +85,8 @@
   },
   {
     "description": "docker uses qualifiers and hash image id as versions",
-    "purl": "pkg:docker/customer/dockerimage@sha256:244fd47e07d1004f0aed9c?repository_url=gcr.io",
-    "canonical_purl": "pkg:docker/customer/dockerimage@sha256:244fd47e07d1004f0aed9c?repository_url=gcr.io",
+    "purl": "pkg:docker/customer/dockerimage@sha256%3A244fd47e07d1004f0aed9c?repository_url=gcr.io",
+    "canonical_purl": "pkg:docker/customer/dockerimage@sha256%3A244fd47e07d1004f0aed9c?repository_url=gcr.io",
     "type": "docker",
     "namespace": "customer",
     "name": "dockerimage",