-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
1. Request
It would be nice, if package_reviewer will make an error, if function open don't have encoding='utf-8'.
2. Justification
I use Cyrillic symbols. In some packages I get similar behavior.
I fix it, if I add encoding='utf-8'. Example:
with open(fSandBox, "a") as myfile:
I change to
with open(fSandBox, "a", encoding='utf-8') as myfile:
It fixed problem. I fix it in 4 Sublime Text packages:
Maybe we have it in other Sublime Text packages, hence I think, that it would be nice, if package_reviewer review it.
3. Desirable behavior
Package developer run package_reviewer → if open function doesn't have encoding='utf-8', developer get error in terminal.
Thanks.