Stop using Resource as a class name, as 'resource' is reserved

Author: bajb

src/Dispatch.php

@@ -80,11 +80,11 @@ public function setHashSalt(string $hashSalt)
    * Generate a hash against specific content, for a desired length
    *
    * @param      $content
-   * @param null $length
+   * @param int  $length
    *
    * @return string
    */
-  public function generateHash($content, $length = null)
+  public function generateHash($content, int $length = null)
   {
     $hash = md5($content . $this->_hashSalt);
     if($length !== null)

src/Resources/AbstractDispatchableResource.php

@@ -32,7 +32,7 @@ public function setProcessingPath($path)
    *
    * @param $content
    *
-   * @return Resource
+   * @return DispatchResource
    */
   public function setContent($content)
   {

src/Resources/AbstractResource.php

@@ -1,7 +1,7 @@
 <?php
 namespace Packaged\Dispatch\Resources;
 
-abstract class AbstractResource implements Resource
+abstract class AbstractResource implements DispatchResource
 {
   protected $_content;
   protected $_options;
@@ -23,7 +23,7 @@ public function getContent()
    *
    * @param $content
    *
-   * @return Resource
+   * @return AbstractResource
    */
   public function setContent($content)
   {

src/Resources/Resource.php src/Resources/DispatchResource.phpsrc/Resources/Resource.php renamed to src/Resources/DispatchResource.php

@@ -1,7 +1,7 @@
 <?php
 namespace Packaged\Dispatch\Resources;
 
-interface Resource
+interface DispatchResource
 {
   public function getExtension();
 

src/Resources/DispatchableResource.php

@@ -3,7 +3,7 @@
 
 use Packaged\Dispatch\ResourceManager;
 
-interface DispatchableResource extends Resource
+interface DispatchableResource extends DispatchResource
 {
   /**
    * Set the asset manager to process sub dispatchables through

src/Resources/JavascriptResource.php

@@ -65,6 +65,7 @@ protected function _minify()
     }
     catch(\Exception $e)
     {
+      //If minification doesnt work, return the original content
     }
   }
 }

src/Resources/ResourceFactory.php

@@ -73,9 +73,9 @@ public static function addExtension($ext, $classname)
   /**
    * @param $extension
    *
-   * @return Resource
+   * @return DispatchResource
    */
-  public static function getExtensionResource($extension): Resource
+  public static function getExtensionResource($extension): DispatchResource
   {
     $extension = strtolower($extension);
     if(isset(self::$_resourceMap[$extension]))
@@ -86,12 +86,12 @@ public static function getExtensionResource($extension): Resource
   }
 
   /**
-   * @param Resource $resource
+   * @param DispatchResource $resource
    *
    * @return Response
    * @throws \Exception
    */
-  public static function create(Resource $resource)
+  public static function create(DispatchResource $resource)
   {
     $response = new Response();
 

tests/Resources/GenericResourceTest.php

@@ -2,7 +2,7 @@
 namespace Packaged\Dispatch\Tests\Resources;
 
 use Packaged\Dispatch\Resources\AbstractResource;
-use Packaged\Dispatch\Resources\Resource;
+use Packaged\Dispatch\Resources\DispatchResource;
 use Packaged\Dispatch\Resources\ResourceFactory;
 use Packaged\Dispatch\Resources\UnknownResource;
 use PHPUnit\Framework\TestCase;
@@ -13,9 +13,9 @@ class GenericResourceTest extends TestCase
    * @dataProvider resourceProvider
    *
    * @param          $ext
-   * @param Resource $class
+   * @param DispatchResource $class
    */
-  public function testResource($ext, Resource $class)
+  public function testResource($ext, DispatchResource $class)
   {
     $extType = [
       "ico"   => "image/x-icon",