Allow per-project opt-out of ELN and Log Detective

Add disabled_projects_for_eln and disabled_projects_for_logdetective
config options to allow opting out specific packages from ELN builds/tests
and Log Detective analysis.

Resolves: #3021
Resolves: #3046

Author: m-blaha

packit_service/config.py

@@ -110,6 +110,8 @@ def __init__(
         fedora_ci_run_by_default: bool = False,
         disabled_projects_for_fedora_ci: Optional[Union[set[str], list[str]]] = None,
         enabled_projects_for_fedora_ci: Optional[Union[set[str], list[str]]] = None,
+        disabled_projects_for_eln: Optional[Union[set[str], list[str]]] = None,
+        disabled_projects_for_logdetective: Optional[Union[set[str], list[str]]] = None,
         rate_limit_threshold: Optional[int] = None,
         logdetective_enabled: bool = False,
         logdetective_url: str = LOGDETECTIVE_PACKIT_SERVER_URL,
@@ -176,6 +178,10 @@ def __init__(
         # e.g.:
         #  - https://src.fedoraproject.org/rpms/python-ogr
         self.disabled_projects_for_fedora_ci: set[str] = set(disabled_projects_for_fedora_ci or [])
+        self.disabled_projects_for_eln: set[str] = set(disabled_projects_for_eln or [])
+        self.disabled_projects_for_logdetective: set[str] = set(
+            disabled_projects_for_logdetective or []
+        )
 
         self.projects_to_sync = projects_to_sync or []
 
@@ -245,10 +251,12 @@ def hide(token: str) -> str:
             f"redhat_api_refresh_token='{hide(self.redhat_api_refresh_token)}', "
             f"package_config_path_override='{self.package_config_path_override}', "
             f"logdetective_enabled='{self.logdetective_enabled}', "
-            f"logdetective_url='{self.logdetective_url}')"
+            f"logdetective_url='{self.logdetective_url}', "
             f"fedora_ci_run_by_default='{self.fedora_ci_run_by_default}', "
             f"enabled_projects_for_fedora_ci='{self.enabled_projects_for_fedora_ci}', "
-            f"disabled_projects_for_fedora_ci='{self.disabled_projects_for_fedora_ci}')"
+            f"disabled_projects_for_fedora_ci='{self.disabled_projects_for_fedora_ci}', "
+            f"disabled_projects_for_eln='{self.disabled_projects_for_eln}', "
+            f"disabled_projects_for_logdetective='{self.disabled_projects_for_logdetective}')"
         )
 
     @classmethod

packit_service/fedora_ci_config.py

@@ -52,3 +52,13 @@ def is_project_enabled(self, project_url: str) -> bool:
             ) and project_url not in self._service_config.disabled_projects_for_fedora_ci
         # Opt-in mode: only run if explicitly enabled
         return project_url in self._service_config.enabled_projects_for_fedora_ci
+
+    def is_eln_enabled(self, project_url: str) -> bool:
+        """Should ELN builds/tests run for this project?"""
+        return project_url not in self._service_config.disabled_projects_for_eln
+
+    def is_logdetective_enabled(self, project_url: str) -> bool:
+        """Should Log Detective analysis run for this project?"""
+        if not self._service_config.logdetective_enabled:
+            return False
+        return project_url not in self._service_config.disabled_projects_for_logdetective

packit_service/schema.py

@@ -87,6 +87,8 @@ class ServiceConfigSchema(UserConfigSchema):
     rate_limit_threshold = fields.Integer(missing=None)
     fedora_ci_run_by_default = fields.Bool(missing=False)
     disabled_projects_for_fedora_ci = fields.List(fields.String())
+    disabled_projects_for_eln = fields.List(fields.String())
+    disabled_projects_for_logdetective = fields.List(fields.String())
     logdetective_enabled = fields.Bool(missing=False, default=False)
     logdetective_url = fields.String()
     logdetective_token = fields.String()

packit_service/worker/checker/distgit.py

@@ -16,6 +16,7 @@
     koji,
     pagure,
 )
+from packit_service.fedora_ci_config import FedoraCIConfig
 from packit_service.utils import (
     get_packit_commands_from_comment,
     pr_labels_match_configuration,
@@ -169,6 +170,17 @@ def pre_check(self) -> bool:
         return True
 
 
+class IsProjectEnabledForELN(Checker):
+    """Verify that the project has not opted out of ELN builds and tests"""
+
+    def pre_check(self) -> bool:
+        project_url = self.project.get_web_url()
+        if not FedoraCIConfig.get_config().is_eln_enabled(project_url):
+            logger.info(f"ELN disabled for project {project_url}, skipping.")
+            return False
+        return True
+
+
 class PackageNeedsELNBuildFromRawhide(Checker, GetPagurePullRequestMixin):
     def pre_check(self) -> bool:
         if (

packit_service/worker/handlers/distgit.py

@@ -78,6 +78,7 @@
 from packit_service.worker.checker.abstract import Checker
 from packit_service.worker.checker.distgit import (
     HasIssueCommenterRetriggeringPermissions,
+    IsProjectEnabledForELN,
     IsProjectInRpmsNamespace,
     IsProjectOk,
     IsUpstreamTagMatchingConfig,
@@ -1024,7 +1025,11 @@ def dist_git_branch(self) -> str:
 
     @staticmethod
     def get_checkers() -> tuple[type[Checker], ...]:
-        return (PermissionOnDistgitForFedoraCI, PackageNeedsELNBuildFromRawhide)
+        return (
+            PermissionOnDistgitForFedoraCI,
+            IsProjectEnabledForELN,
+            PackageNeedsELNBuildFromRawhide,
+        )
 
 
 class AbstractDownstreamKojiBuildHandler(

packit_service/worker/handlers/koji.py

@@ -30,6 +30,7 @@
     gitlab,
     koji,
 )
+from packit_service.fedora_ci_config import FedoraCIConfig
 from packit_service.models import (
     AbstractProjectObjectDbType,
     KojiBuildTargetModel,
@@ -383,8 +384,9 @@ def trigger_log_detective_if_configured(self):
         Since the analysis is not crucial for the build task itself, we only log
         when the LD trigger failed, and not return a failed TaskResult
         """
-        if not self.service_config.logdetective_enabled:
-            logger.info("Log Detective disabled in config, skipping.")
+        project_url = self.project.get_web_url()
+        if not FedoraCIConfig.get_config().is_logdetective_enabled(project_url):
+            logger.info(f"Log Detective disabled for project {project_url}, skipping.")
             return
         logger.info("Triggering Log Detective Helper for a failed Koji build")
         log_detective_trigger = LogDetectiveKojiTriggerHelper(

packit_service/worker/handlers/testing_farm.py

@@ -42,6 +42,7 @@
 from packit_service.utils import elapsed_seconds, get_default_tf_mapping
 from packit_service.worker.checker.abstract import Checker
 from packit_service.worker.checker.distgit import (
+    IsProjectEnabledForELN,
     IsProjectInRpmsNamespace,
     IsProjectInTestsNamespace,
     PackageNeedsELNBuildFromRawhide,
@@ -538,6 +539,7 @@ class DownstreamTestingFarmELNHandler(DownstreamTestingFarmHandler):
     def get_checkers() -> tuple[type[Checker], ...]:
         return (
             IsProjectInRpmsNamespace,
+            IsProjectEnabledForELN,
             PackageNeedsELNBuildFromRawhide,
             HasEventSuccessfulRawhideELNScratchBuild,
             PermissionOnDistgitForFedoraCI,

tests/integration/test_dg_pr.py

@@ -104,12 +104,16 @@ def test_downstream_koji_scratch_build(distgit_pr_event, target_branch, uid, che
         .should_receive("get_git_urls")
         .and_return({"git": "https://src.fedoraproject.org/rpms/optee_os.git"})
         .mock()
+        .should_receive("get_web_url")
+        .and_return("https://src.fedoraproject.org/rpms/optee_os")
+        .mock()
     )
     service_config = (
         flexmock(
             enabled_projects_for_fedora_ci="https://src.fedoraproject.org/rpms/optee_os",
             fedora_ci_run_by_default=False,
             disabled_projects_for_fedora_ci=set(),
+            disabled_projects_for_eln=set(),
             command_handler_work_dir=SANDCASTLE_WORK_DIR,
             repository_cache="/tmp/repository-cache",
             add_repositories_to_repository_cache=False,

tests/integration/test_koji_build_cancel.py

@@ -73,12 +73,16 @@ def mock_distgit_pr_functionality():
         .should_receive("get_git_urls")
         .and_return({"git": "https://src.fedoraproject.org/rpms/optee_os.git"})
         .mock()
+        .should_receive("get_web_url")
+        .and_return("https://src.fedoraproject.org/rpms/optee_os")
+        .mock()
     )
     service_config = (
         flexmock(
             enabled_projects_for_fedora_ci="https://src.fedoraproject.org/rpms/optee_os",
             fedora_ci_run_by_default=False,
             disabled_projects_for_fedora_ci=set(),
+            disabled_projects_for_eln=set(),
             command_handler_work_dir=SANDCASTLE_WORK_DIR,
             repository_cache="/tmp/repository-cache",
             add_repositories_to_repository_cache=False,

tests/integration/test_listen_to_fedmsg.py

@@ -2609,6 +2609,9 @@ def test_koji_build_end_downstream(
             enabled_projects_for_fedora_ci="https://src.fedoraproject.org/rpms/packit",
             fedora_ci_run_by_default=False,
             disabled_projects_for_fedora_ci=set(),
+            disabled_projects_for_eln=set(),
+            logdetective_enabled=False,
+            disabled_projects_for_logdetective=set(),
             koji_logs_url="",
             koji_web_url="",
             deployment=Deployment.stg,
@@ -3332,6 +3335,7 @@ def test_pagure_pr_updated(pagure_pr_updated, project_namespace, project_repo):
             testing_farm_api_url="API URL",
             fedora_ci_run_by_default=True,
             disabled_projects_for_fedora_ci=set(),
+            disabled_projects_for_eln=set(),
             koji_logs_url="",
             koji_web_url="",
             command_handler_work_dir=SANDCASTLE_WORK_DIR,