feat(clis/exceptions): Exception Mapper Updates from Static Tests (ethereum#1493)

* feat(clis): Exceptions from static tests pt1

* fix: more mapper exceptions

* fix(clis/ethereumjs): tox

* added two ergion mappings as requested by som

* fix: erigon exceptions move

* fix(clis/erigon): Add invalid gas used exception

* feat(exceptions): Add Invalid-Gas-Used-Above-Limit

* feat(clis/all): Add exception messages

---------

Co-authored-by: Felix H <[email protected]>

Author: 2 people

src/ethereum_clis/clis/besu.py

@@ -213,12 +213,17 @@ class BesuExceptionMapper(ExceptionMapper):
     """Translate between EEST exceptions and error strings returned by Besu."""
 
     mapping_substring: ClassVar[Dict[ExceptionBase, str]] = {
+        TransactionException.NONCE_IS_MAX: "invalid Nonce must be less than",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: (
             "transaction invalid tx max fee per blob gas less than block blob gas fee"
         ),
+        TransactionException.GASLIMIT_PRICE_PRODUCT_OVERFLOW: (
+            "invalid Upfront gas cost cannot exceed 2^256 Wei"
+        ),
         TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS: (
             "transaction invalid gasPrice is less than the current BaseFee"
         ),
+        TransactionException.GAS_ALLOWANCE_EXCEEDED: "provided gas insufficient",
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: (
             "transaction invalid max priority fee per gas cannot be greater than max fee per gas"
         ),
@@ -259,6 +264,7 @@ class BesuExceptionMapper(ExceptionMapper):
         BlockException.INCORRECT_BLOB_GAS_USED: (
             "Payload BlobGasUsed does not match calculated BlobGasUsed"
         ),
+        BlockException.INVALID_GAS_USED_ABOVE_LIMIT: "Header validation failed (FULL)",
         # TODO EVMONE needs to differentiate when the section is missing in the header or body
         EOFException.MISSING_STOP_OPCODE: "err: no_terminating_instruction",
         EOFException.MISSING_CODE_HEADER: "err: code_section_missing",

src/ethereum_clis/clis/erigon.py

@@ -12,11 +12,13 @@ class ErigonExceptionMapper(ExceptionMapper):
         TransactionException.INSUFFICIENT_ACCOUNT_FUNDS: (
             "insufficient funds for gas * price + value"
         ),
+        TransactionException.NONCE_IS_MAX: "nonce has max value",
         TransactionException.INTRINSIC_GAS_TOO_LOW: "intrinsic gas too low",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS: "fee cap less than block base fee",
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: "tip higher than fee cap",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: "max fee per blob gas too low",
         TransactionException.NONCE_MISMATCH_TOO_LOW: "nonce too low",
+        TransactionException.GAS_ALLOWANCE_EXCEEDED: "gas limit reached",
         TransactionException.TYPE_3_TX_PRE_FORK: "blob txn is not supported by signer",
         TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH: (
             "invalid blob versioned hash, must start with VERSIONED_HASH_VERSION_KZG"
@@ -33,10 +35,14 @@ class ErigonExceptionMapper(ExceptionMapper):
         TransactionException.TYPE_4_TX_CONTRACT_CREATION: "wrong size for To: 0",
         TransactionException.TYPE_4_TX_PRE_FORK: "setCode tx is not supported by signer",
         TransactionException.INVALID_DEPOSIT_EVENT_LAYOUT: "could not parse requests logs",
+        BlockException.SYSTEM_CONTRACT_EMPTY: "Syscall failure: Empty Code at",
+        BlockException.SYSTEM_CONTRACT_CALL_FAILED: "Unprecedented Syscall failure",
         BlockException.INVALID_REQUESTS: "invalid requests root hash in header",
         BlockException.INVALID_BLOCK_HASH: "invalid block hash",
     }
     mapping_regex = {
         BlockException.INCORRECT_BLOB_GAS_USED: r"blobGasUsed by execution: \d+, in header: \d+",
         BlockException.INCORRECT_EXCESS_BLOB_GAS: r"invalid excessBlobGas: have \d+, want \d+",
+        BlockException.INVALID_GAS_USED: r"gas used by execution: \w+, in header: \w+",
+        BlockException.INVALID_GAS_USED_ABOVE_LIMIT: r"invalid gasUsed: have \d+, gasLimit \d+",
     }

src/ethereum_clis/clis/ethereumjs.py

@@ -55,9 +55,11 @@ class EthereumJSExceptionMapper(ExceptionMapper):
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: (
             "Invalid 4844 transactions: undefined"
         ),
-        TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS: (
-            "tx unable to pay base fee (EIP-1559 tx)"
+        TransactionException.GASLIMIT_PRICE_PRODUCT_OVERFLOW: (
+            "gas limit * gasPrice cannot exceed MAX_INTEGER"
         ),
+        TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS: "tx unable to pay base fee",
+        TransactionException.NONCE_IS_MAX: "nonce cannot equal or exceed",
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: (
             "maxFeePerGas cannot be less than maxPriorityFeePerGas"
         ),
@@ -85,7 +87,10 @@ class EthereumJSExceptionMapper(ExceptionMapper):
             "sender doesn't have enough funds to send tx"
         ),
         TransactionException.NONCE_MISMATCH_TOO_LOW: "the tx doesn't have the correct nonce",
-        TransactionException.INVALID_DEPOSIT_EVENT_LAYOUT: "Error verifying block while running",
+        TransactionException.INVALID_DEPOSIT_EVENT_LAYOUT: (
+            "Error verifying block while running: error: number exceeds 53 bits"
+        ),
+        TransactionException.GAS_ALLOWANCE_EXCEEDED: "tx has a higher gas limit than the block",
         BlockException.INCORRECT_EXCESS_BLOB_GAS: "Invalid 4844 transactions",
         BlockException.INVALID_RECEIPTS_ROOT: "invalid receipttrie",
         # TODO EVMONE needs to differentiate when the section is missing in the header or body
@@ -147,4 +152,7 @@ class EthereumJSExceptionMapper(ExceptionMapper):
             r"Invalid blockHash, expected: 0x[0-9a-f]+, received: 0x[0-9a-f]+"
         ),
         BlockException.INVALID_REQUESTS: r"Unknown request identifier|invalid requestshash",
+        BlockException.INVALID_GAS_USED_ABOVE_LIMIT: (
+            r"Invalid block: too much gas used. Used: \d+, gas limit: \d+"
+        ),
     }

src/ethereum_clis/clis/geth.py

@@ -29,9 +29,11 @@ class GethExceptionMapper(ExceptionMapper):
 
     mapping_substring: ClassVar[Dict[ExceptionBase, str]] = {
         TransactionException.SENDER_NOT_EOA: "sender not an eoa",
+        TransactionException.GAS_ALLOWANCE_EXCEEDED: "gas limit reached",
         TransactionException.INSUFFICIENT_ACCOUNT_FUNDS: (
             "insufficient funds for gas * price + value"
         ),
+        TransactionException.NONCE_IS_MAX: "nonce has max value",
         TransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED: (
             "would exceed maximum allowance"
         ),
@@ -122,6 +124,7 @@ class GethExceptionMapper(ExceptionMapper):
         BlockException.BLOB_GAS_USED_ABOVE_LIMIT: (
             r"blob gas used \d+ exceeds maximum allowance \d+"
         ),
+        BlockException.INVALID_GAS_USED_ABOVE_LIMIT: r"invalid gasUsed: have \d+, gasLimit \d+",
     }
 
 

src/ethereum_clis/clis/nethermind.py

@@ -328,6 +328,8 @@ class NethermindExceptionMapper(ExceptionMapper):
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: (
             "InvalidMaxPriorityFeePerGas: Cannot be higher than maxFeePerGas"
         ),
+        TransactionException.GAS_ALLOWANCE_EXCEEDED: "Block gas limit exceeded",
+        TransactionException.NONCE_IS_MAX: "nonce overflow",
         TransactionException.INITCODE_SIZE_EXCEEDED: "max initcode size exceeded",
         TransactionException.NONCE_MISMATCH_TOO_LOW: "wrong transaction nonce",
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: (
@@ -354,6 +356,9 @@ class NethermindExceptionMapper(ExceptionMapper):
             "HeaderBlobGasMismatch: Blob gas in header does not match calculated"
         ),
         BlockException.INVALID_REQUESTS: "InvalidRequestsHash: Requests hash mismatch in block",
+        BlockException.INVALID_GAS_USED_ABOVE_LIMIT: (
+            "ExceededGasLimit: Gas used exceeds gas limit."
+        ),
     }
     mapping_regex = {
         TransactionException.INSUFFICIENT_ACCOUNT_FUNDS: (

src/ethereum_clis/clis/reth.py

@@ -19,6 +19,7 @@ class RethExceptionMapper(ExceptionMapper):
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: (
             "priority fee is greater than max fee"
         ),
+        TransactionException.GASLIMIT_PRICE_PRODUCT_OVERFLOW: "overflow",
         TransactionException.TYPE_3_TX_CONTRACT_CREATION: "unexpected length",
         TransactionException.TYPE_3_TX_WITH_FULL_BLOBS: "unexpected list",
         TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH: "blob version not supported",
@@ -47,11 +48,17 @@ class RethExceptionMapper(ExceptionMapper):
         TransactionException.TYPE_3_TX_ZERO_BLOBS: (
             r"blob transactions present in pre-cancun payload|empty blobs"
         ),
-        BlockException.SYSTEM_CONTRACT_CALL_FAILED: (r"failed to apply .* requests contract call"),
+        TransactionException.GAS_ALLOWANCE_EXCEEDED: (
+            r"transaction gas limit \w+ is more than blocks available gas \w+"
+        ),
+        BlockException.SYSTEM_CONTRACT_CALL_FAILED: r"failed to apply .* requests contract call",
         BlockException.INCORRECT_BLOB_GAS_USED: (
             r"blob gas used mismatch|blob gas used \d+ is not a multiple of blob gas per blob"
         ),
         BlockException.INCORRECT_EXCESS_BLOB_GAS: (
             r"excess blob gas \d+ is not a multiple of blob gas per blob|invalid excess blob gas"
         ),
+        BlockException.INVALID_GAS_USED_ABOVE_LIMIT: (
+            r"block used gas \(\d+\) is greater than gas limit \(\d+\)"
+        ),
     }

src/ethereum_test_exceptions/exceptions.py

@@ -495,6 +495,10 @@ class BlockException(ExceptionBase):
     """
     Block header's actual gas used does not match the provided header's value
     """
+    INVALID_GAS_USED_ABOVE_LIMIT = auto()
+    """
+    Block header's gas used value is above the gas limit field's value.
+    """
     INVALID_WITHDRAWALS_ROOT = auto()
     """
     Block header's withdrawals root does not match calculated withdrawals root.