fix: improve test coverage

Author: tuan-pham

tests/test_message_pact.py

@@ -103,6 +103,42 @@ def test_definition_without_given(self):
             target._messages[0]['metaData'],
             {'source': 'legacy_api'})
 
+class MessagePactContextManagerTestCase(MessagePactTestCase):
+    def setUp(self):
+        super(MessagePactContextManagerTestCase, self).setUp()
+        self.addCleanup(patch.stopall)
+
+        self.write_to_pact_file = patch.object(
+            message_pact.MessagePact, 'write_to_pact_file', autospec=True).start()
+        self.write_to_pact_file.return_value.returncode = 0
+
+        self.mock_publish = patch.object(
+            message_pact.MessagePact, 'publish', autospec=True).start()
+        self.mock_publish.return_value.returncode = 0
+
+    def test_successful(self):
+        pact = MessagePact(
+            self.consumer, self.provider, publish_to_broker=True,
+            broker_base_url='http://localhost', broker_username='username', broker_password='password')
+
+        with pact:
+            pass
+
+        self.write_to_pact_file.assert_called_once()
+        self.mock_publish.assert_called_once()
+
+    def test_context_raises_error(self):
+        pact = MessagePact(
+            self.consumer, self.provider, publish_to_broker=True,
+            broker_base_url='http://localhost', broker_username='username', broker_password='password')
+
+        with self.assertRaises(RuntimeError):
+            with pact:
+                raise RuntimeError
+
+        self.write_to_pact_file.assert_not_called()
+        self.mock_publish.assert_not_called()
+
 
 class PactGeneratePactFileTestCase(TestCase):
     def setUp(self):
@@ -117,7 +153,7 @@ def setUp(self):
     def test_call_pact_message_to_generate_pact_file(self):
         target = MessagePact(
             self.consumer, self.provider, pact_dir='/pacts',
-            version='3.0.0', file_write_mode='merge')
+            version='3.0.0', file_write_mode='merge', publish_to_broker=True)
 
         (target
             .given('There is an alligator named John')

tests/test_pact.py

@@ -5,6 +5,7 @@
 from mock import patch, call, Mock
 from psutil import Process
 
+from pact.broker import Broker
 from pact.consumer import Consumer, Provider
 from pact.matchers import Term
 from pact.constants import MOCK_SERVICE_PATH
@@ -294,6 +295,8 @@ def setUp(self):
             pact.Pact, '_wait_for_server_start', autospec=True).start()
         self.mock_Pid_exists = patch.object(
             pact.psutil, 'pid_exists', autospec=True).start()
+        self.mock_publish = patch.object(
+            Broker, 'publish', autospec=True).start()
 
     def test_start_fails(self):
         self.mock_Popen.return_value.returncode = 1
@@ -352,21 +355,23 @@ def test_start_with_ssl(self):
             '--sslkey', '/ssl.key'])
 
     def test_stop_posix(self):
+        self.mock_publish.return_value.returncode = 0
         self.mock_platform.return_value = 'Linux'
         pact = Pact(Consumer('consumer'), Provider('provider'))
         pact._process = Mock(spec=Popen, pid=999, returncode=0)
         pact.stop_service()
 
         pact._process.terminate.assert_called_once_with()
         pact._process.communicate.assert_called_once_with()
+        self.mock_publish.assert_not_called()
         self.assertFalse(self.mock_Process.called)
 
     def test_stop_windows(self):
         self.mock_platform.return_value = 'Windows'
         ruby_exe = Mock(spec=Process)
         self.mock_Process.return_value.children.return_value = [ruby_exe]
         self.mock_Pid_exists.return_value = False
-        pact = Pact(Consumer('consumer'), Provider('provider'))
+        pact = Pact(Consumer('consumer'), Provider('provider'), publish_to_broker=True)
         pact._process = Mock(spec=Popen, pid=999)
         pact.stop_service()
 
@@ -378,6 +383,7 @@ def test_stop_windows(self):
         ruby_exe.terminate.assert_called_once_with()
         self.mock_Process.return_value.wait.assert_called_once_with()
         self.mock_Pid_exists.assert_called_once_with(999)
+        self.mock_publish.assert_called_once()
 
     def test_stop_fails_posix(self):
         self.mock_platform.return_value = 'Linux'
@@ -389,6 +395,7 @@ def test_stop_fails_posix(self):
 
         pact._process.terminate.assert_called_once_with()
         pact._process.communicate.assert_called_once_with()
+        self.mock_publish.assert_not_called()
 
     def test_stop_fails_windows(self):
         self.mock_platform.return_value = 'Windows'
@@ -407,6 +414,7 @@ def test_stop_fails_windows(self):
             recursive=True)
         self.mock_Process.return_value.wait.assert_called_once_with()
         self.mock_Pid_exists.assert_called_once_with(999)
+        self.mock_publish.assert_not_called()
 
 
 class PactWaitForServerStartTestCase(TestCase):