Skip to content

Commit 5db7100

Browse files
committed
feat(verifier): allow to use unauthenticated brokers
1 parent a7d4171 commit 5db7100

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

pact/verify_wrapper.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,8 @@ class VerifyWrapper(object):
125125
"""A Pact Verifier Wrapper."""
126126

127127
def _broker_present(self, **kwargs):
128-
if (kwargs.get('broker_username') is None
129-
or kwargs.get('broker_password') is None
130-
or kwargs.get('broker_url') is None):
131-
128+
if kwargs.get('broker_url') is None:
132129
return False
133-
134130
return True
135131

136132
def call_verify(

tests/test_verify_wrapper.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,18 @@ def test_pact_urls_or_broker_required(self):
8080

8181
self.assertTrue('Pact urls or Pact broker required' in context.exception.message)
8282

83+
def test_broker_without_authentication_can_be_used(self):
84+
self.mock_Popen.return_value.returncode = 0
85+
wrapper = VerifyWrapper()
86+
wrapper.call_verify(
87+
provider='provider', provider_base_url='http://localhost', broker_url='http://broker.example.com'
88+
)
89+
self.assertProcess(*[
90+
'--provider-base-url=http://localhost',
91+
'--provider=provider',
92+
'--pact-broker-base-url=http://broker.example.com',
93+
])
94+
8395
def test_pact_urls_provided(self):
8496
self.mock_Popen.return_value.returncode = 0
8597
wrapper = VerifyWrapper()

0 commit comments

Comments
 (0)