Skip to content

Commit 80e4f21

Browse files
committed
chore(ci): fix publish step
There was an issue with releasing Pact Python 3.0.1 and Pact Python FFI 0.4.28.2 whereby the release changelog could not be generated (despite the rest of the changelog being generated fine). This inserts a placeholder to be filled in, as opposed to failing the release entirely. Ref: https://github.com/pact-foundation/pact-python/actions/runs/18270656326/job/52012475672 Signed-off-by: JP-Ellis <[email protected]>
1 parent a76857d commit 80e4f21

File tree

3 files changed

+57
-12
lines changed

3 files changed

+57
-12
lines changed

.github/workflows/build-cli.yml

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,27 @@ jobs:
154154
id: release-changelog
155155
working-directory: pact-python-cli
156156
run: |
157-
git cliff \
157+
if ! git cliff \
158158
--current \
159159
--strip header \
160-
--output ${{ runner.temp }}/release-changelog.md
161-
162-
echo -e "\n\n## Pull Requests\n\n" >> ${{ runner.temp }}/release-changelog.md
160+
--output ${{ runner.temp }}/release-changelog.md; then
161+
{
162+
echo "> [!WARNING]"
163+
echo ">"
164+
echo "> No changelog generated. To be filled in."
165+
} > ${{ runner.temp }}/release-changelog.md
166+
fi
167+
168+
{
169+
echo ""
170+
echo "<details>"
171+
echo "<summary>"
172+
echo ""
173+
echo "## Pull Requests"
174+
echo ""
175+
echo "</summary>"
176+
echo ""
177+
} >> ${{ runner.temp }}/release-changelog.md
163178
env:
164179
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
165180

.github/workflows/build-ffi.yml

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,27 @@ jobs:
155155
id: release-changelog
156156
working-directory: pact-python-ffi
157157
run: |
158-
git cliff \
158+
if ! git cliff \
159159
--current \
160160
--strip header \
161-
--output ${{ runner.temp }}/release-changelog.md
162-
163-
echo -e "\n\n## Pull Requests\n\n" >> ${{ runner.temp }}/release-changelog.md
161+
--output ${{ runner.temp }}/release-changelog.md ; then
162+
{
163+
echo "> [!WARNING]"
164+
echo ">"
165+
echo "> No changelog generated. To be filled in."
166+
} > ${{ runner.temp }}/release-changelog.md
167+
fi
168+
169+
{
170+
echo ""
171+
echo "<details>"
172+
echo "<summary>"
173+
echo ""
174+
echo "## Pull Requests"
175+
echo ""
176+
echo "</summary>"
177+
echo ""
178+
} >> ${{ runner.temp }}/release-changelog.md
164179
env:
165180
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
166181

.github/workflows/build.yml

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,27 @@ jobs:
121121
- name: Generate release changelog
122122
id: release-changelog
123123
run: |
124-
git cliff \
124+
if ! git cliff \
125125
--current \
126126
--strip header \
127-
--output ${{ runner.temp }}/release-changelog.md
128-
129-
echo -e "\n\n## Pull Requests\n\n" >> ${{ runner.temp }}/release-changelog.md
127+
--output ${{ runner.temp }}/release-changelog.md; then
128+
{
129+
echo "> [!WARNING]"
130+
echo ">"
131+
echo "> No changelog generated. To be filled in."
132+
} > ${{ runner.temp }}/release-changelog.md
133+
fi
134+
135+
{
136+
echo ""
137+
echo "<details>"
138+
echo "<summary>"
139+
echo ""
140+
echo "## Pull Requests"
141+
echo ""
142+
echo "</summary>"
143+
echo ""
144+
} >> ${{ runner.temp }}/release-changelog.md
130145
env:
131146
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
132147

0 commit comments

Comments
 (0)