Skip to content

Commit f169f3b

Browse files
authored
ci: python36-support-removed (#283)
* build(python36): remove 3.6 from CI. Remove check for multiprocessing * docs(examples): correct link, removing e2e * style(example): remove unused import
1 parent c431b4f commit f169f3b

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

.github/workflows/build_and_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
runs-on: ubuntu-latest
99
strategy:
1010
matrix:
11-
python-version: [3.6, 3.7, 3.8, 3.9]
11+
python-version: [3.7, 3.8, 3.9]
1212

1313
steps:
1414
- uses: actions/checkout@v2

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ pip install pact-python
2323

2424
## Getting started
2525
<!-- Absolute link for rendering page in docs.pact.io -->
26-
A guide follows but if you go to the [e2e examples](https://github.com/pact-foundation/pact-python/tree/master/examples/e2e). This has a consumer, provider and pact-broker set of tests.
26+
A guide follows but if you go to the [examples](https://github.com/pact-foundation/pact-python/tree/master/examples). This has a consumer, provider and pact-broker set of tests for both FastAPI and Flask.
2727

2828
## Writing a Pact
2929

examples/fastapi_provider/tests/conftest.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import pathlib
2-
import sys
32
from multiprocessing import Process
43

54
import docker
@@ -16,11 +15,7 @@ def server():
1615
yield proc
1716

1817
# Cleanup after test
19-
if sys.version_info >= (3, 7):
20-
# multiprocessing.kill is new in 3.7
21-
proc.kill()
22-
else:
23-
proc.terminate()
18+
proc.kill()
2419

2520

2621
def pytest_addoption(parser):

0 commit comments

Comments
 (0)