Skip to content

Commit fafc3d5

Browse files
Merge pull request #147 from pact-foundation/feat/add_logging_params
Added logging params
2 parents b6450b8 + 8ce7d44 commit fafc3d5

File tree

3 files changed

+26
-8
lines changed

3 files changed

+26
-8
lines changed

examples/e2e/tests/userserviceclient-userservice.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@
1919
},
2020
"body": {
2121
"name": "UserA",
22-
"id": "00000000-0000-4000-a000-000000000000",
22+
"id": "fc763eba-0905-41c5-a27f-3934ab26786c",
2323
"created_on": "2016-12-15T20:16:01",
24+
"ip_address": "127.0.0.1",
2425
"admin": false
2526
},
2627
"matchingRules": {
@@ -29,11 +30,15 @@
2930
},
3031
"$.body.id": {
3132
"match": "regex",
32-
"regex": "^[a-f0-9]{8}-?[a-f0-9]{4}-?4[a-f0-9]{3}-?[89ab][a-f0-9]{3}-?[a-f0-9]{12}\\Z"
33+
"regex": "[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"
3334
},
3435
"$.body.created_on": {
3536
"match": "regex",
3637
"regex": "\\d+-\\d+-\\d+T\\d+:\\d+:\\d+"
38+
},
39+
"$.body.ip_address": {
40+
"match": "regex",
41+
"regex": "(\\d{1,3}\\.)+\\d{1,3}"
3742
}
3843
}
3944
}

pact/verify.py

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@
99

1010
from .constants import VERIFIER_PATH
1111

12-
if sys.version_info.major == 2:
13-
import subprocess32 as subprocess
14-
else:
15-
import subprocess
12+
import subprocess
1613

1714

1815
@click.command()
@@ -104,10 +101,20 @@
104101
'--verbose/--no-verbose',
105102
default=False,
106103
help='Toggle verbose logging, defaults to False.')
104+
@click.option(
105+
'--verbose/--no-verbose',
106+
default=False,
107+
help='Toggle verbose logging, defaults to False.')
108+
@click.option(
109+
'log_dir', '--log-dir',
110+
help='The directory for the pact.log file.')
111+
@click.option(
112+
'log_level', '--log-level',
113+
help='The logging level.')
107114
def main(pacts, base_url, pact_url, pact_urls, states_url, states_setup_url,
108115
username, broker_base_url, consumer_version_tag, provider_version_tag,
109116
password, token, provider, headers, timeout, provider_app_version,
110-
publish_verification_results, verbose):
117+
publish_verification_results, verbose, log_dir, log_level):
111118
"""
112119
Verify one or more contracts against a provider service.
113120
@@ -151,7 +158,9 @@ def main(pacts, base_url, pact_url, pact_urls, states_url, states_setup_url,
151158
'--pact-broker-base-url': broker_base_url,
152159
'--provider': provider,
153160
'--broker-password': password,
154-
'--broker-token': token
161+
'--broker-token': token,
162+
'--log-dir': log_dir,
163+
'--log-level': log_level
155164
}
156165

157166
command = [VERIFIER_PATH]

tests/test_verify.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ def test_all_url_options(self):
159159
'--provider=provider',
160160
'--publish-verification-results',
161161
'--provider-app-version=1.2.3',
162+
'--log-dir=tmp/logs/pact.test.log',
163+
'--log-level=INFO',
162164
'--timeout=60',
163165
'--verbose'
164166
])
@@ -182,6 +184,8 @@ def test_all_url_options(self):
182184
'--provider=provider',
183185
'--publish-verification-results',
184186
'--provider-app-version', '1.2.3',
187+
'--log-dir=tmp/logs/pact.test.log',
188+
'--log-level=INFO',
185189
'--verbose')
186190

187191
def test_all_broker_options(self):

0 commit comments

Comments
 (0)