fix: ensure we always print mismatchs in consumer tests for better dx

Author: YOU54F

lib/pact/v2/consumer/grpc_interaction_builder.rb

@@ -149,13 +149,13 @@ def execute(&block)
 
           yield(message_pact, mock_server)
 
+        ensure
           if mock_server.matched?
             mock_server.write_pacts!(@pact_config.pact_dir)
           else
             msg = mismatches_error_msg(mock_server)
             raise InteractionMismatchesError.new(msg)
           end
-        ensure
           @used = true
           mock_server&.cleanup
           PactFfi::PluginConsumer.cleanup_plugins(pact_handle)

lib/pact/v2/consumer/http_interaction_builder.rb

@@ -113,13 +113,13 @@ def execute(&block)
 
           yield(mock_server)
 
+        ensure
           if mock_server.matched?
             mock_server.write_pacts!(pact_config.pact_dir)
           else
             msg = mismatches_error_msg(mock_server)
             raise InteractionMismatchesError.new(msg)
           end
-        ensure
           @used = true
           mock_server&.cleanup
           # Reset the pact handle to allow for a new interaction to be built

lib/pact/v2/consumer/plugin_async_message_interaction_builder.rb

@@ -108,7 +108,6 @@ def execute(&block)
                 if v.nil? || (v.respond_to?(:empty?) && v.empty?)
                   PactFfi.given(interaction, provider_state)
                 else
-                  puts "Given #{provider_state} with param #{k}: #{v}"
                   PactFfi.given_with_param(interaction, provider_state, k.to_s, v.to_s)
                 end
                 end
@@ -126,13 +125,14 @@ def execute(&block)
           mock_server = MockServer.create_for_transport!(pact: pact_handle, transport: @transport, host: @pact_config.mock_host, port: @pact_config.mock_port)
 
           yield(pact_handle, mock_server)
+
+        ensure
           if mock_server.matched?
             mock_server.write_pacts!(@pact_config.pact_dir)
           else
             msg = mismatches_error_msg(mock_server)
             raise InteractionMismatchesError.new(msg)
           end
-        ensure
           @used = true
           mock_server&.cleanup
           PactFfi::PluginConsumer.cleanup_plugins(pact_handle) if pact_handle

lib/pact/v2/consumer/plugin_http_interaction_builder.rb

@@ -125,7 +125,6 @@ def execute(&block)
                 if v.nil? || (v.respond_to?(:empty?) && v.empty?)
                   PactFfi.given(interaction, provider_state)
                 else
-                  puts "Given #{provider_state} with param #{k}: #{v}"
                   PactFfi.given_with_param(interaction, provider_state, k.to_s, v.to_s)
                 end
                 end
@@ -148,13 +147,14 @@ def execute(&block)
           mock_server = MockServer.create_for_transport!(pact: pact_handle, transport: @transport || 'http', host: @pact_config.mock_host, port: @pact_config.mock_port)
 
           yield(mock_server)
+
+        ensure
           if mock_server.matched?
             mock_server.write_pacts!(@pact_config.pact_dir)
           else
             msg = mismatches_error_msg(mock_server)
             raise InteractionMismatchesError.new(msg)
           end
-        ensure
           @used = true
           mock_server&.cleanup
           PactFfi::PluginConsumer.cleanup_plugins(pact_handle) if pact_handle

lib/pact/v2/consumer/plugin_sync_message_interaction_builder.rb

@@ -135,13 +135,13 @@ def execute(&block)
 
           yield(message_pact, mock_server)
 
+        ensure
           if mock_server.matched?
             mock_server.write_pacts!(@pact_config.pact_dir)
           else
             msg = mismatches_error_msg(mock_server)
             raise InteractionMismatchesError.new(msg)
           end
-        ensure
           @used = true
           mock_server&.cleanup
           PactFfi::PluginConsumer.cleanup_plugins(pact_handle)

spec/spec_helper_v2.rb

@@ -6,6 +6,8 @@
 require "rspec"
 require "rspec_junit_formatter"
 
+is_windows = Gem.win_platform?
+
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
@@ -15,6 +17,7 @@
   end
 
   config.filter_run_when_matching :focus
+  config.filter_run_excluding skip_windows: is_windows
   config.example_status_persistence_file_path = "tmp/rspec_examples.txt"
   config.run_all_when_everything_filtered = true