First attempt at tomlifying tox
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added a commit
that referenced
this pull request
Oct 1, 2024
paddyroddy
added a commit
that referenced
this pull request
Oct 1, 2024
paddyroddy
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit a2d0373.
paddyroddy
added a commit
that referenced
this pull request
Oct 1, 2024
paddyroddy
added a commit
that referenced
this pull request
Oct 1, 2024
paddyroddy
added a commit
that referenced
this pull request
Oct 1, 2024
gaborbernat
suggested changes
Oct 1, 2024
| [tox] | ||
| env_list = py{310,311,312}-{linux,macos,windows} | ||
| """ | ||
| env.testenv = {commands = [ |
There was a problem hiding this comment.
This does not look right. I think you want here https://tox.wiki/en/4.21.0/config.html#pyproject-toml-native env_run_base, testenv is a INI concept.
There was a problem hiding this comment.
Yeah, I realised that afterwards (this PR has been reverted). I just tried to do it blind before spotting the docs. I can give it another go now!
paddyroddy
added a commit
that referenced
this pull request
Oct 11, 2024
Second attempt and fixing #173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following tox-dev/tox#3353 there is now full native TOML support for
tox