test: add tests for first-turn-moves (#7095)

* test: add tests for first impression

* fix mat block error

Author: Bertie690

src/data/moves/move-condition.ts

@@ -49,7 +49,7 @@ export class FirstMoveCondition extends MoveCondition {
     super(user => user.tempSummonData.waveTurnCount === 1);
   }
 
-  // TODO: Update AI move selection logic to not require this method at all
+  // TODO: Update AI move selection logic to not require this method (and this class) at all
   // Currently, it is used to avoid having the AI select the move if its condition will fail
   getUserBenefitScore(user: Pokemon, _target: Pokemon, _move: Move): number {
     return this.apply(user, _target, _move) ? 10 : -20;

test/tests/moves/fake-out.test.ts test/tests/moves/first-turn-moves.test.tstest/tests/moves/fake-out.test.ts renamed to test/tests/moves/first-turn-moves.test.ts

@@ -1,10 +1,15 @@
 import { MoveId } from "#enums/move-id";
+import { MoveResult } from "#enums/move-result";
 import { SpeciesId } from "#enums/species-id";
 import { GameManager } from "#test/framework/game-manager";
 import Phaser from "phaser";
 import { beforeAll, beforeEach, describe, expect, it } from "vitest";
 
-describe("Moves - Fake Out", () => {
+describe.each([
+  { move: MoveId.FAKE_OUT, name: "Fake Out" },
+  { move: MoveId.FIRST_IMPRESSION, name: "First Impression" },
+  { move: MoveId.MAT_BLOCK, name: "Mat Block" },
+])("Move - $name", ({ move }) => {
   let phaserGame: Phaser.Game;
   let game: GameManager;
 
@@ -18,64 +23,56 @@ describe("Moves - Fake Out", () => {
     game = new GameManager(phaserGame);
     game.override
       .battleStyle("single")
-      .enemySpecies(SpeciesId.CORVIKNIGHT)
+      .enemySpecies(SpeciesId.SHUCKLE)
       .enemyMoveset(MoveId.SPLASH)
-      .enemyLevel(10)
-      .startingLevel(1) // prevent LevelUpPhase from happening
+      .enemyLevel(100)
+      .startingLevel(100)
       .criticalHits(false);
   });
 
   it("should only work the first turn a pokemon is sent out in a battle", async () => {
     await game.classicMode.startBattle(SpeciesId.FEEBAS);
 
-    game.move.use(MoveId.FAKE_OUT);
+    game.move.use(move);
     await game.toNextTurn();
 
-    const corv = game.field.getEnemyPokemon();
-    expect(corv).not.toHaveFullHp();
-    corv.hp = corv.getMaxHp();
+    const feebas = game.field.getPlayerPokemon();
+    expect(feebas).toHaveUsedMove({ move, result: MoveResult.SUCCESS });
 
-    game.move.use(MoveId.FAKE_OUT);
-    await game.toNextTurn();
+    game.move.use(move);
+    await game.toEndOfTurn();
 
-    expect(corv).toHaveFullHp();
+    expect(feebas).toHaveUsedMove({ move, result: MoveResult.FAIL });
   });
 
-  // This is a PokeRogue buff to Fake Out
+  // This is a PokeRogue buff to Fake Out & co.
   it("should succeed at the start of each new wave, even if user wasn't recalled", async () => {
     await game.classicMode.startBattle(SpeciesId.FEEBAS);
 
-    // set hp to 1 for easy knockout
-    game.field.getEnemyPokemon().hp = 1;
-    game.move.use(MoveId.FAKE_OUT);
+    game.move.use(MoveId.SPLASH);
+    await game.doKillOpponents();
     await game.toNextWave();
 
-    game.move.use(MoveId.FAKE_OUT);
+    game.move.use(move);
     await game.toNextTurn();
 
-    const corv = game.field.getEnemyPokemon();
-    expect(corv).not.toHaveFullHp();
+    const feebas = game.field.getPlayerPokemon();
+    expect(feebas).toHaveUsedMove({ move, result: MoveResult.SUCCESS });
   });
 
   it("should succeed if recalled and sent back out", async () => {
     await game.classicMode.startBattle(SpeciesId.FEEBAS, SpeciesId.MAGIKARP);
 
-    game.move.use(MoveId.FAKE_OUT);
-    await game.toNextTurn();
-
-    const corv = game.field.getEnemyPokemon();
-    expect(corv).not.toHaveFullHp();
-    corv.hp = corv.getMaxHp();
-
     game.doSwitchPokemon(1);
     await game.toNextTurn();
 
     game.doSwitchPokemon(1);
     await game.toNextTurn();
 
-    game.move.use(MoveId.FAKE_OUT);
+    game.move.use(move);
     await game.toNextTurn();
 
-    expect(corv).not.toHaveFullHp();
+    const feebas = game.field.getPlayerPokemon();
+    expect(feebas).toHaveUsedMove({ move, result: MoveResult.SUCCESS });
   });
 });

test/tests/moves/mat-block.test.ts

@@ -64,24 +64,5 @@ describe("Moves - Mat Block", () => {
     leadPokemon.forEach(p => expect(p.getStatStage(Stat.ATK)).toBe(-2));
   });
 
-  test("should fail when used after the first turn", async () => {
-    await game.classicMode.startBattle(SpeciesId.BLASTOISE, SpeciesId.CHARIZARD);
-
-    const leadPokemon = game.scene.getPlayerField();
-
-    game.move.select(MoveId.SPLASH);
-    game.move.select(MoveId.SPLASH, 1);
-
-    await game.phaseInterceptor.to("TurnEndPhase");
-
-    const leadStartingHp = leadPokemon.map(p => p.hp);
-
-    await game.phaseInterceptor.to("CommandPhase", false);
-    game.move.select(MoveId.MAT_BLOCK);
-    game.move.select(MoveId.MAT_BLOCK, 1);
-
-    await game.phaseInterceptor.to("BerryPhase", false);
-
-    expect(leadPokemon.some((p, i) => p.hp < leadStartingHp[i])).toBeTruthy();
-  });
+  // first turn behavior covered inside first-turn-moves.test.ts
 });