refactor: Lane ctor, set default for level = false as defined in OpenDrive

Author: pageldev

include/Lane.h

@@ -50,13 +50,13 @@ inline std::ostream& operator<<(std::ostream& os, const LaneKey& lk)
 
 struct Lane
 {
-    Lane(int id, bool level, std::string type);
+    Lane(int id, std::string type, bool level = false);
 
     std::vector<SingleRoadMark> get_roadmarks(const double s_start, const double s_end) const;
 
     int         id;
-    bool        level = false;
-    std::string type = "";
+    std::string type;
+    bool        level;
 
     std::optional<int> predecessor;
     std::optional<int> successor;

src/Lane.cpp

@@ -19,7 +19,7 @@ std::string LaneKey::to_string() const
     return fmt::format("{}/{:.17g}/{}", this->road_id, this->lanesection_s0, this->lane_id);
 }
 
-Lane::Lane(int id, bool level, std::string type) : id(id), level(level), type(type) {}
+Lane::Lane(int id, std::string type, bool level) : id(id), type(type), level(level) {}
 
 std::vector<SingleRoadMark> Lane::get_roadmarks(const double s_start, const double s_end) const
 {

src/OpenDriveMap.cpp

@@ -403,7 +403,7 @@ OpenDriveMap::OpenDriveMap(const std::string& xodr_file,
 
                 Lane& lane =
                     lanesection.id_to_lane
-                        .emplace(lane_id, Lane(lane_id, lane_node.attribute("level").as_bool(false), lane_node.attribute("type").as_string("")))
+                        .emplace(lane_id, Lane(lane_id, lane_node.attribute("type").as_string(""), lane_node.attribute("level").as_bool(false)))
                         .first->second;
 
                 if (const pugi::xml_attribute id_attr = lane_node.child("link").child("predecessor").attribute("id"))