fix: [PAYMCLOUD-750] fix typo and use one secret for repository pull (#153)

fix: fix typo and use one secret for repository pull

Author: ffppa

README.md

@@ -235,7 +235,7 @@ Specify a name of the secret to pull the image from a private registry.
 
 ```yaml
   imagePullSecret:
-    - name: NAME_OF_IMAGE_PULL_SECRET
+    name: NAME_OF_IMAGE_PULL_SECRET
 ```
 
 ### `configMapFromFile`: load file defined inside internal value configMap and mount in a pod as file

charts/microservice-chart/README.md

@@ -1,6 +1,6 @@
 # microservice-chart
 
-![Version: 8.1.1](https://img.shields.io/badge/Version-8.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.0](https://img.shields.io/badge/AppVersion-0.0.0-informational?style=flat-square)
+![Version: 8.1.2](https://img.shields.io/badge/Version-8.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.0](https://img.shields.io/badge/AppVersion-0.0.0-informational?style=flat-square)
 
 A Helm chart for PagoPA microservice
 
@@ -53,7 +53,7 @@ A Helm chart for PagoPA microservice
 | image.pullPolicy | string | `"Always"` | Pull policy to use |
 | image.repository | string | `""` | Docker reposity for the container |
 | image.tag | string | `"v0.0.0"` | Container TAG |
-| imagePullSecrets | list | `[]` | imagePullSecrets: use a Secret to pull an image from a private container image registry or repository |
+| imagePullSecrets | object | `{"name":""}` | imagePullSecrets: use a Secret to pull an image from a private container image registry or repository |
 | ingress | object | - | Ingress configuration |
 | ingress.annotations | map | `{}` | custom annotations for ingress |
 | ingress.create | bool | `false` | Create or not the ingress manifest |

charts/microservice-chart/templates/deployments.yaml

@@ -261,10 +261,12 @@ spec:
         {{- with .Values.sidecars }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
-      {{- if not (empty .Values.imagePullSerets) }}
+      {{- if and .Values.imagePullSecrets (kindIs "map" .Values.imagePullSecrets) -}}
+      {{- if .Values.imagePullSecrets.name }}
       imagePullSecrets:
         - name: {{ .Values.imagePullSecrets.name }}
       {{- end }}
+      {{- end }}
       {{- if .Values.initContainers }}
       initContainers:
         {{- range .Values.initContainers }}

charts/microservice-chart/values.yaml

@@ -54,7 +54,8 @@ image:
   pullPolicy: Always
 
 # -- imagePullSecrets: use a Secret to pull an image from a private container image registry or repository
-imagePullSecrets: []
+imagePullSecrets:
+  name: ""
 
 # -- Sidecars, each object has exactly the same schema as a Pod, except it does not have an apiVersion or kind
 sidecars: []

tests/v8-java-helm-complete-test-bar/helm/Chart.yaml

@@ -6,5 +6,5 @@ version: 1.0.0
 appVersion: 1.0.0
 dependencies:
 - name: microservice-chart
-  version: 8.1.1
+  version: 8.1.2
   repository: file://../../../charts/microservice-chart