Skip to content

Commit 5eaa5ad

Browse files
Merge pull request #983 from pagopa/copilot-new
Refactor PR writing agents for improved consistency
2 parents eab2267 + ae3ecf1 commit 5eaa5ad

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

.github/agents/tech-ai-github-pr-writer.agent.md renamed to .github/agents/tech-ai-pr-editor.agent.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
description: Create or update pull request title/body using repository template and real diff context.
3-
name: TechAIPRWriter
3+
name: TechAIPREditor
44
tools: ["search", "usages", "problems", "fetch", "githubRepo"]
55
---
66

.github/prompts/tech-ai-github-pr-description.prompt.md renamed to .github/prompts/tech-ai-pr-description.prompt.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
description: Build a complete pull request body using the existing repository PR template
33
name: TechAIPRDescription
4-
agent: TechAIPRWriter
4+
agent: TechAIPREditor
55
argument-hint: title=<text> intent=<text> changed_files=<comma-separated paths> [validation=<commands/results>] [risk=<Low|Medium|High>] [links=<issue/docs/runbook>] [target_branch=<name>] [pr_number=<number>]
66
---
77

@@ -25,7 +25,7 @@ Create or update a pull request body using the repository template (`.github/PUL
2525
- Do not add extra sections unless the template already includes them.
2626

2727
## Instructions
28-
1. Use `.github/skills/tech-ai-pr-writing/SKILL.md`.
28+
1. Use `.github/skills/tech-ai-pr-editor/SKILL.md`.
2929
2. Resolve the template path in this order:
3030
- `.github/PULL_REQUEST_TEMPLATE.md`
3131
- `.github/pull_request_template.md`

.github/scripts/validate-copilot-customizations.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ prompt_expected_name() {
306306
tech-ai-github-composite-action.prompt.md)
307307
printf '%s' "TechAICompositeAction"
308308
;;
309-
tech-ai-github-pr-description.prompt.md)
309+
tech-ai-pr-description.prompt.md)
310310
printf '%s' "TechAIPRDescription"
311311
;;
312312
tech-ai-add-platform.prompt.md)
@@ -773,7 +773,7 @@ validate_agents_dir() {
773773
record_issue "$semantic_severity" "Reviewer agent should reference code review instructions: ${file}"
774774
fi
775775
;;
776-
tech-ai-global-customization-builder.agent.md)
776+
tech-ai-standards-repo-config-builder.agent.md)
777777
if ! has_heading_exact "$file" '## Source of truth'; then
778778
record_issue "$semantic_severity" "Global customization builder missing '## Source of truth' section: ${file}"
779779
fi
@@ -801,11 +801,11 @@ validate_agents_dir() {
801801
if ! grep -Fq 'scripts/validate-copilot-customizations.sh' "$file"; then
802802
record_issue "$semantic_severity" "Global customization builder should reference customization validator: ${file}"
803803
fi
804-
if ! grep -Fq 'TechAIGlobalCustomizationAuditor' "$file"; then
805-
record_issue "$semantic_severity" "Global customization builder should hand off to TechAIGlobalCustomizationAuditor: ${file}"
804+
if ! grep -Fq 'TechAIStandardsRepoConfigAuditor' "$file"; then
805+
record_issue "$semantic_severity" "Global customization builder should hand off to TechAIStandardsRepoConfigAuditor: ${file}"
806806
fi
807807
;;
808-
tech-ai-global-customization-auditor.agent.md)
808+
tech-ai-standards-repo-config-auditor.agent.md)
809809
if ! has_heading_exact "$file" '## Audit protocol'; then
810810
record_issue "$semantic_severity" "Global customization auditor missing '## Audit protocol' section: ${file}"
811811
fi
@@ -821,8 +821,8 @@ validate_agents_dir() {
821821
if ! grep -Fq 'scripts/validate-copilot-customizations.sh' "$file"; then
822822
record_issue "$semantic_severity" "Global customization auditor should reference customization validator: ${file}"
823823
fi
824-
if ! grep -Fq 'TechAIGlobalCustomizationBuilder' "$file"; then
825-
record_issue "$semantic_severity" "Global customization auditor should route major findings to TechAIGlobalCustomizationBuilder: ${file}"
824+
if ! grep -Fq 'TechAIStandardsRepoConfigBuilder' "$file"; then
825+
record_issue "$semantic_severity" "Global customization auditor should route major findings to TechAIStandardsRepoConfigBuilder: ${file}"
826826
fi
827827
;;
828828
esac

.github/skills/tech-ai-pr-writing/SKILL.md renamed to .github/skills/tech-ai-pr-editor/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: TechAIPRWriting
2+
name: TechAIPREditor
33
description: Produce concise, complete pull request descriptions aligned with the repository PR template.
44
---
55

.github/tech-ai-sync-copilot-configs.manifest.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
"sha256": "1991b994bc59e81ec0900e3ba808b8982f429fb7079cd80939bc0542fadbac2e",
77
"source_relative_path": ".github/DEPRECATION.md"
88
},
9-
".github/agents/tech-ai-github-pr-writer.agent.md": {
9+
".github/agents/tech-ai-pr-editor.agent.md": {
1010
"generated": false,
1111
"sha256": "41006031bdf76dc89ad5653d717ab0f960aac87679711a2a527cd2168301228a",
12-
"source_relative_path": ".github/agents/tech-ai-github-pr-writer.agent.md"
12+
"source_relative_path": ".github/agents/tech-ai-pr-editor.agent.md"
1313
},
1414
".github/agents/tech-ai-github-workflow-supply-chain.agent.md": {
1515
"generated": false,
@@ -146,10 +146,10 @@
146146
"sha256": "e4a4c547ccbfd263851bd6977a418446095eb3f94e349dffca3b6ae4e4dc731b",
147147
"source_relative_path": ".github/prompts/tech-ai-github-composite-action.prompt.md"
148148
},
149-
".github/prompts/tech-ai-github-pr-description.prompt.md": {
149+
".github/prompts/tech-ai-pr-description.prompt.md": {
150150
"generated": false,
151151
"sha256": "90d80e3c8979f961a50939358c58ce3ae749308613a9ffcb91da5992c4895fe9",
152-
"source_relative_path": ".github/prompts/tech-ai-github-pr-description.prompt.md"
152+
"source_relative_path": ".github/prompts/tech-ai-pr-description.prompt.md"
153153
},
154154
".github/prompts/tech-ai-python-script.prompt.md": {
155155
"generated": false,
@@ -201,10 +201,10 @@
201201
"sha256": "d1b989c1fde0c9da9d5d5e762aec9955e77dcdc3f60612fe06ad9c733411e302",
202202
"source_relative_path": ".github/skills/tech-ai-data-registry/SKILL.md"
203203
},
204-
".github/skills/tech-ai-pr-writing/SKILL.md": {
204+
".github/skills/tech-ai-pr-editor/SKILL.md": {
205205
"generated": false,
206206
"sha256": "773a7fc63895186617a14cf5806fb64c15d6fc534e2e74c35f850eadb8decafc",
207-
"source_relative_path": ".github/skills/tech-ai-pr-writing/SKILL.md"
207+
"source_relative_path": ".github/skills/tech-ai-pr-editor/SKILL.md"
208208
},
209209
".github/skills/tech-ai-project-python/SKILL.md": {
210210
"generated": false,
@@ -241,6 +241,6 @@
241241
"source_commit": "463be334cb56ad74a0e759709f0a48f6b13354c4",
242242
"source_version": "1.0.0",
243243
"target_repo": "/Users/diego.lagosmorales/code/building-blocks-technology/oneidentity",
244-
"tool": "TechAISyncCopilotConfigs",
244+
"tool": "TechAISyncGlobalCopilotConfigsIntoRepo",
245245
"version": 1
246246
}

AGENTS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ This file is for GitHub Copilot and AI assistants working in this repository.
2929
- Use `TechAIIAMLeastPrivilege` for role and permission scoping checks.
3030
- Use `TechAIWorkflowSupplyChain` for workflow supply-chain hardening and CI checks.
3131
- Use `TechAISecurityReviewer` as the security-focused review gate.
32-
- Use `TechAIPRWriter` when generating pull request content from the repository template.
32+
- Use `TechAIPREditor` when generating pull request content from the repository template.
3333

3434
### Agent composition
3535
- For changes spanning multiple specialist domains, run each relevant specialist and aggregate findings.
@@ -116,7 +116,7 @@ This inventory reflects the desired managed baseline plus repository-owned inter
116116
- `.github/prompts/tech-ai-data-registry.prompt.md`
117117
- `.github/prompts/tech-ai-github-action.prompt.md`
118118
- `.github/prompts/tech-ai-github-composite-action.prompt.md`
119-
- `.github/prompts/tech-ai-github-pr-description.prompt.md`
119+
- `.github/prompts/tech-ai-pr-description.prompt.md`
120120
- `.github/prompts/tech-ai-python-script.prompt.md`
121121
- `.github/prompts/tech-ai-python.prompt.md`
122122
- `.github/prompts/tech-ai-terraform.prompt.md`
@@ -127,7 +127,7 @@ This inventory reflects the desired managed baseline plus repository-owned inter
127127
- `.github/skills/tech-ai-cloud-policy/SKILL.md`
128128
- `.github/skills/tech-ai-composite-action/SKILL.md`
129129
- `.github/skills/tech-ai-data-registry/SKILL.md`
130-
- `.github/skills/tech-ai-pr-writing/SKILL.md`
130+
- `.github/skills/tech-ai-pr-editor/SKILL.md`
131131
- `.github/skills/tech-ai-project-python/SKILL.md`
132132
- `.github/skills/tech-ai-script-bash/SKILL.md`
133133
- `.github/skills/tech-ai-script-python/SKILL.md`
@@ -136,7 +136,7 @@ This inventory reflects the desired managed baseline plus repository-owned inter
136136

137137
### Agents
138138
- `.github/agents/internal-oneidentity-repo-specialist.agent.md`
139-
- `.github/agents/tech-ai-github-pr-writer.agent.md`
139+
- `.github/agents/tech-ai-pr-editor.agent.md`
140140
- `.github/agents/tech-ai-github-workflow-supply-chain.agent.md`
141141
- `.github/agents/tech-ai-iam-least-privilege.agent.md`
142142
- `.github/agents/tech-ai-implementer.agent.md`

0 commit comments

Comments
 (0)