Fix include path exported by BackwardConfig.cmake #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@maltevonehren Thank you for opening the PR. We will review it in the upcoming days. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the following issue when trying to include
backward.hppinstalled from this library:In the
Backward::Backwardtarget, the include path (exported throughINTERFACE_INCLUDE_DIRECTORIES) was set to the directory that containsBackwardConfig.cmake(xxx/share/backward_ros/cmake) rather than the one that containsbackward.hpp(xxx/include/backward_ros).This MR changes the include path to point to the correct directory.
In my case this fixed the issue and I think it makes sense to include this change in general or let me know if I'm missing something here.