From 392ded24478a83ba70a835ed202aee2742be8636 Mon Sep 17 00:00:00 2001 From: Pritham Marupaka Date: Mon, 28 Jul 2025 16:36:01 -0400 Subject: [PATCH 1/6] wip --- .../conjure/java/client/config/ClientConfiguration.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java b/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java index f988e7541..09f51784b 100644 --- a/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java +++ b/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java @@ -127,6 +127,8 @@ public interface ClientConfiguration { /** Per-host failures are recorded using this interface. */ Optional hostEventsSink(); + Optional supportsConjureErrorDeserializationAsJson(); + @Value.Check default void check() { if (meshProxy().isPresent()) { From 292dc63f64bc5056c1e70c8565e8e6877d9d5f8d Mon Sep 17 00:00:00 2001 From: Pritham Marupaka Date: Tue, 29 Jul 2025 16:45:57 -0400 Subject: [PATCH 2/6] Add withConjureErrorParameterSerializationFormat to WithClientOptions --- client-config/build.gradle | 1 + .../conjure/java/client/config/ClientConfiguration.java | 2 -- .../java/com/palantir/conjure/java/clients/ConjureClients.java | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/client-config/build.gradle b/client-config/build.gradle index aa8f52670..f397f2b65 100644 --- a/client-config/build.gradle +++ b/client-config/build.gradle @@ -3,6 +3,7 @@ apply plugin: 'org.revapi.revapi-gradle-plugin' dependencies { api 'com.palantir.conjure.java.api:service-config' + api 'com.palantir.conjure.java.api:errors' api 'com.palantir.tritium:tritium-registry' api 'com.google.errorprone:error_prone_annotations' api 'com.palantir.refreshable:refreshable' diff --git a/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java b/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java index 09f51784b..f988e7541 100644 --- a/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java +++ b/client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java @@ -127,8 +127,6 @@ public interface ClientConfiguration { /** Per-host failures are recorded using this interface. */ Optional hostEventsSink(); - Optional supportsConjureErrorDeserializationAsJson(); - @Value.Check default void check() { if (meshProxy().isPresent()) { diff --git a/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java b/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java index 06b3ea53a..b12d179e4 100644 --- a/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java +++ b/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java @@ -20,6 +20,7 @@ import com.palantir.conjure.java.api.config.service.ServiceConfiguration; import com.palantir.conjure.java.api.config.service.ServicesConfigBlock; import com.palantir.conjure.java.api.config.service.UserAgent; +import com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat; import com.palantir.conjure.java.client.config.ClientConfiguration; import com.palantir.conjure.java.client.config.HostEventsSink; import com.palantir.conjure.java.client.config.NodeSelectionStrategy; @@ -88,6 +89,8 @@ public interface WithClientOptions { /** Per-host success/failure information will be recorded to this sink. */ T withHostEventsSink(HostEventsSink hostEventsSink); + + T withConjureErrorParameterSerializationFormat(ConjureErrorParameterFormat format); } public interface ToReloadingFactory { From c348f8857a1261f148fa7aaa2cdaa9162912b71b Mon Sep 17 00:00:00 2001 From: Pritham Marupaka Date: Tue, 12 Aug 2025 14:03:10 -0400 Subject: [PATCH 3/6] revapi --- .palantir/revapi.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.palantir/revapi.yml b/.palantir/revapi.yml index 026e181ef..b31a30049 100644 --- a/.palantir/revapi.yml +++ b/.palantir/revapi.yml @@ -79,3 +79,8 @@ acceptedBreaks: - code: "java.class.removed" old: "enum com.palantir.conjure.java.server.jersey.ErrorCause" justification: "ErrorCause is never used by consumers" + "8.22.0": + com.palantir.conjure.java.runtime:client-config: + - code: "java.method.addedToInterface" + new: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions::withConjureErrorParameterSerializationFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" + justification: "Allowing clients to request error parameter serialization format" From 8c79e9c288d6e3076039a855c05076ffd156a605 Mon Sep 17 00:00:00 2001 From: svc-autorelease Date: Thu, 14 Aug 2025 15:24:35 +0000 Subject: [PATCH 4/6] Release 8.24.0-rc1 [skip ci] From b9959229cf8d106fdeb59a7154923ab7fddfa0d8 Mon Sep 17 00:00:00 2001 From: Pritham Marupaka Date: Mon, 18 Aug 2025 13:48:11 -0400 Subject: [PATCH 5/6] review change --- .palantir/revapi.yml | 5 +++-- .../com/palantir/conjure/java/clients/ConjureClients.java | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.palantir/revapi.yml b/.palantir/revapi.yml index b31a30049..bc11363f3 100644 --- a/.palantir/revapi.yml +++ b/.palantir/revapi.yml @@ -82,5 +82,6 @@ acceptedBreaks: "8.22.0": com.palantir.conjure.java.runtime:client-config: - code: "java.method.addedToInterface" - new: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions::withConjureErrorParameterSerializationFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" - justification: "Allowing clients to request error parameter serialization format" + new: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions::withConjureErrorParameterFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" + justification: "Adding method to allow clients to request error parameter serialization\ + \ format" diff --git a/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java b/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java index b12d179e4..fd2ea7382 100644 --- a/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java +++ b/client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java @@ -90,7 +90,7 @@ public interface WithClientOptions { /** Per-host success/failure information will be recorded to this sink. */ T withHostEventsSink(HostEventsSink hostEventsSink); - T withConjureErrorParameterSerializationFormat(ConjureErrorParameterFormat format); + T withConjureErrorParameterFormat(ConjureErrorParameterFormat format); } public interface ToReloadingFactory { From e3f7b7b37d432eb9a1b167fa07a2ebc9b8cdb030 Mon Sep 17 00:00:00 2001 From: Pritham Marupaka Date: Tue, 19 Aug 2025 10:47:58 -0400 Subject: [PATCH 6/6] update revapi --- .palantir/revapi.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.palantir/revapi.yml b/.palantir/revapi.yml index bc11363f3..5a651edd9 100644 --- a/.palantir/revapi.yml +++ b/.palantir/revapi.yml @@ -79,9 +79,13 @@ acceptedBreaks: - code: "java.class.removed" old: "enum com.palantir.conjure.java.server.jersey.ErrorCause" justification: "ErrorCause is never used by consumers" - "8.22.0": + "8.24.0-rc1": com.palantir.conjure.java.runtime:client-config: - code: "java.method.addedToInterface" new: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions::withConjureErrorParameterFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" justification: "Adding method to allow clients to request error parameter serialization\ \ format" + - code: "java.method.removed" + old: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions::withConjureErrorParameterSerializationFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" + justification: "Adding method to allow clients to request error parameter serialization\ + \ format"